From 447728ff200fbbcb527a102e7598adb229cf58c3 Mon Sep 17 00:00:00 2001
From: Alison Goryachev
Date: Wed, 16 Jun 2021 11:02:55 -0400
Subject: [PATCH] [Watcher] Migrate to use new page layout (#101956)
---
.../translations/translations/ja-JP.json | 2 -
.../translations/translations/zh-CN.json | 2 -
.../watcher/public/application/app.tsx | 44 +++---
.../components/page_error/page_error.tsx | 2 +-
.../page_error/page_error_forbidden.tsx | 3 +-
.../page_error/page_error_not_exist.tsx | 22 ++-
.../json_watch_edit/json_watch_edit.tsx | 64 +++-----
.../monitoring_watch_edit.tsx | 56 ++-----
.../threshold_watch_edit.tsx | 27 ++--
.../watch_edit/components/watch_edit.tsx | 53 +++----
.../watch_list/components/watch_list.tsx | 149 ++++++++----------
.../watch_status/components/watch_status.tsx | 146 ++++++++---------
.../public/application/shared_imports.ts | 1 +
13 files changed, 262 insertions(+), 309 deletions(-)
diff --git a/x-pack/plugins/translations/translations/ja-JP.json b/x-pack/plugins/translations/translations/ja-JP.json
index fcb5710f8208f9..fb936a58387816 100644
--- a/x-pack/plugins/translations/translations/ja-JP.json
+++ b/x-pack/plugins/translations/translations/ja-JP.json
@@ -24295,8 +24295,6 @@
"xpack.watcher.sections.watchEdit.json.titlePanel.editWatchTitle": "{watchName}を編集",
"xpack.watcher.sections.watchEdit.loadingWatchDescription": "ウォッチの読み込み中…",
"xpack.watcher.sections.watchEdit.loadingWatchVisualizationDescription": "ウォッチビジュアライゼーションを読み込み中…",
- "xpack.watcher.sections.watchEdit.monitoring.edit.calloutDescriptionText": "ウォッチ'{watchName}'はシステムウォッチであるため、編集できません。{watchStatusLink}",
- "xpack.watcher.sections.watchEdit.monitoring.edit.calloutTitleText": "このウォッチは編集できません。",
"xpack.watcher.sections.watchEdit.monitoring.header.watchLinkTitle": "ウォッチステータスを表示します。",
"xpack.watcher.sections.watchEdit.simulate.form.actionModesFieldLabel": "アクションモード",
"xpack.watcher.sections.watchEdit.simulate.form.actionOverridesDescription": "ウォッチでアクションを実行またはスキップすることができるようにします。{actionsLink}",
diff --git a/x-pack/plugins/translations/translations/zh-CN.json b/x-pack/plugins/translations/translations/zh-CN.json
index 8c865b62d9d1ab..998b2a4c672872 100644
--- a/x-pack/plugins/translations/translations/zh-CN.json
+++ b/x-pack/plugins/translations/translations/zh-CN.json
@@ -24665,8 +24665,6 @@
"xpack.watcher.sections.watchEdit.json.titlePanel.editWatchTitle": "编辑 {watchName}",
"xpack.watcher.sections.watchEdit.loadingWatchDescription": "正在加载监视……",
"xpack.watcher.sections.watchEdit.loadingWatchVisualizationDescription": "正在加载监视可视化……",
- "xpack.watcher.sections.watchEdit.monitoring.edit.calloutDescriptionText": "监视“{watchName}”为系统监视,无法编辑。{watchStatusLink}",
- "xpack.watcher.sections.watchEdit.monitoring.edit.calloutTitleText": "此监视无法编辑。",
"xpack.watcher.sections.watchEdit.monitoring.header.watchLinkTitle": "查看监视状态。",
"xpack.watcher.sections.watchEdit.simulate.form.actionModesFieldLabel": "操作模式",
"xpack.watcher.sections.watchEdit.simulate.form.actionOverridesDescription": "允许监视执行或跳过操作。{actionsLink}",
diff --git a/x-pack/plugins/watcher/public/application/app.tsx b/x-pack/plugins/watcher/public/application/app.tsx
index 6c233a44830b54..98d10bce3b6b24 100644
--- a/x-pack/plugins/watcher/public/application/app.tsx
+++ b/x-pack/plugins/watcher/public/application/app.tsx
@@ -17,7 +17,7 @@ import {
import { Router, Switch, Route, Redirect, withRouter, RouteComponentProps } from 'react-router-dom';
-import { EuiCallOut, EuiLink } from '@elastic/eui';
+import { EuiPageContent, EuiEmptyPrompt, EuiLink } from '@elastic/eui';
import { FormattedMessage } from '@kbn/i18n/react';
@@ -62,24 +62,30 @@ export const App = (deps: AppDeps) => {
if (!valid) {
return (
-
- }
- color="danger"
- iconType="help"
- >
- {message}{' '}
-
-
-
-
+
+
+
+
+ }
+ body={{message}
}
+ actions={[
+
+
+ ,
+ ]}
+ />
+
);
}
return (
diff --git a/x-pack/plugins/watcher/public/application/components/page_error/page_error.tsx b/x-pack/plugins/watcher/public/application/components/page_error/page_error.tsx
index ca05d390518f26..321b5c0e5e11b7 100644
--- a/x-pack/plugins/watcher/public/application/components/page_error/page_error.tsx
+++ b/x-pack/plugins/watcher/public/application/components/page_error/page_error.tsx
@@ -25,7 +25,7 @@ export function getPageErrorCode(errorOrErrors: any) {
}
}
-export function PageError({ errorCode, id }: { errorCode?: any; id?: any }) {
+export function PageError({ errorCode, id }: { errorCode?: number; id?: string }) {
switch (errorCode) {
case 404:
return ;
diff --git a/x-pack/plugins/watcher/public/application/components/page_error/page_error_forbidden.tsx b/x-pack/plugins/watcher/public/application/components/page_error/page_error_forbidden.tsx
index c2e93c7f066001..56dc5c7dc22b53 100644
--- a/x-pack/plugins/watcher/public/application/components/page_error/page_error_forbidden.tsx
+++ b/x-pack/plugins/watcher/public/application/components/page_error/page_error_forbidden.tsx
@@ -13,8 +13,7 @@ import { FormattedMessage } from '@kbn/i18n/react';
export function PageErrorForbidden() {
return (
-
+ {id ? (
+
+ ) : (
+
+ )}
}
/>
diff --git a/x-pack/plugins/watcher/public/application/sections/watch_edit/components/json_watch_edit/json_watch_edit.tsx b/x-pack/plugins/watcher/public/application/sections/watch_edit/components/json_watch_edit/json_watch_edit.tsx
index 8b5827fbd0fe0d..80931c3f60c05a 100644
--- a/x-pack/plugins/watcher/public/application/sections/watch_edit/components/json_watch_edit/json_watch_edit.tsx
+++ b/x-pack/plugins/watcher/public/application/sections/watch_edit/components/json_watch_edit/json_watch_edit.tsx
@@ -7,15 +7,7 @@
import React, { useContext, useState } from 'react';
-import {
- EuiFlexGroup,
- EuiFlexItem,
- EuiPageContent,
- EuiSpacer,
- EuiTab,
- EuiTabs,
- EuiTitle,
-} from '@elastic/eui';
+import { EuiPageHeader, EuiSpacer, EuiPageContentBody } from '@elastic/eui';
import { i18n } from '@kbn/i18n';
import { ExecuteDetails } from '../../../../models/execute_details';
import { getActionType } from '../../../../../../common/lib/get_action_type';
@@ -96,36 +88,31 @@ export const JsonWatchEdit = ({ pageTitle }: { pageTitle: string }) => {
const hasExecuteWatchErrors = !!Object.keys(executeWatchErrors).find(
(errorKey) => executeWatchErrors[errorKey].length >= 1
);
+
return (
-
-
-
-
- {pageTitle}
-
-
-
-
- {WATCH_TABS.map((tab, index) => (
- {
- setSelectedTab(tab.id);
- setExecuteDetails(
- new ExecuteDetails({
- ...executeDetails,
- actionModes: getActionModes(watchActions),
- })
- );
- }}
- isSelected={tab.id === selectedTab}
- key={index}
- data-test-subj="tab"
- >
- {tab.name}
-
- ))}
-
+
+ {pageTitle}}
+ bottomBorder
+ tabs={WATCH_TABS.map((tab, index) => ({
+ onClick: () => {
+ setSelectedTab(tab.id);
+ setExecuteDetails(
+ new ExecuteDetails({
+ ...executeDetails,
+ actionModes: getActionModes(watchActions),
+ })
+ );
+ },
+ isSelected: tab.id === selectedTab,
+ key: index,
+ 'data-test-subj': 'tab',
+ label: tab.name,
+ }))}
+ />
+
+
{selectedTab === WATCH_SIMULATE_TAB && (
{
watchActions={watchActions}
/>
)}
+
{selectedTab === WATCH_EDIT_TAB && }
-
+
);
};
diff --git a/x-pack/plugins/watcher/public/application/sections/watch_edit/components/monitoring_watch_edit/monitoring_watch_edit.tsx b/x-pack/plugins/watcher/public/application/sections/watch_edit/components/monitoring_watch_edit/monitoring_watch_edit.tsx
index 930c11340ce5e3..b00e4dc310e27e 100644
--- a/x-pack/plugins/watcher/public/application/sections/watch_edit/components/monitoring_watch_edit/monitoring_watch_edit.tsx
+++ b/x-pack/plugins/watcher/public/application/sections/watch_edit/components/monitoring_watch_edit/monitoring_watch_edit.tsx
@@ -7,16 +7,7 @@
import React, { useContext } from 'react';
-import {
- EuiFlexGroup,
- EuiFlexItem,
- EuiPageContent,
- EuiSpacer,
- EuiTitle,
- EuiCallOut,
- EuiText,
- EuiLink,
-} from '@elastic/eui';
+import { EuiPageContent, EuiEmptyPrompt, EuiLink } from '@elastic/eui';
import { FormattedMessage } from '@kbn/i18n/react';
import { WatchContext } from '../../watch_context';
import { useAppContext } from '../../../../app_context';
@@ -27,46 +18,31 @@ export const MonitoringWatchEdit = ({ pageTitle }: { pageTitle: string }) => {
const { watch } = useContext(WatchContext);
const { history } = useAppContext();
- const systemWatchTitle = (
-
- );
-
const systemWatchMessage = (
-
-
- ),
}}
/>
);
return (
-
-
-
-
- {pageTitle}
-
-
-
-
-
-
- {systemWatchMessage}
-
-
+
+ {pageTitle}}
+ body={{systemWatchMessage}
}
+ actions={[
+
+
+ ,
+ ]}
+ />
);
};
diff --git a/x-pack/plugins/watcher/public/application/sections/watch_edit/components/threshold_watch_edit/threshold_watch_edit.tsx b/x-pack/plugins/watcher/public/application/sections/watch_edit/components/threshold_watch_edit/threshold_watch_edit.tsx
index 2f89a3bc2be641..6587974363a802 100644
--- a/x-pack/plugins/watcher/public/application/sections/watch_edit/components/threshold_watch_edit/threshold_watch_edit.tsx
+++ b/x-pack/plugins/watcher/public/application/sections/watch_edit/components/threshold_watch_edit/threshold_watch_edit.tsx
@@ -18,13 +18,14 @@ import {
EuiFlexGroup,
EuiFlexItem,
EuiForm,
- EuiPageContent,
EuiPopover,
EuiPopoverTitle,
EuiSelect,
EuiSpacer,
EuiText,
EuiTitle,
+ EuiPageHeader,
+ EuiPageContentBody,
} from '@elastic/eui';
import { i18n } from '@kbn/i18n';
import { FormattedMessage } from '@kbn/i18n/react';
@@ -236,19 +237,15 @@ export const ThresholdWatchEdit = ({ pageTitle }: { pageTitle: string }) => {
};
return (
-
-
-
-
- {pageTitle}
-
-
-
- {watch.titleDescription}
-
-
-
-
+
+ {pageTitle}}
+ description={watch.titleDescription}
+ bottomBorder
+ />
+
+
+
{serverError && (
@@ -957,6 +954,6 @@ export const ThresholdWatchEdit = ({ pageTitle }: { pageTitle: string }) => {
close={() => setIsRequestVisible(false)}
/>
) : null}
-
+
);
};
diff --git a/x-pack/plugins/watcher/public/application/sections/watch_edit/components/watch_edit.tsx b/x-pack/plugins/watcher/public/application/sections/watch_edit/components/watch_edit.tsx
index 525ae077df655f..fa3c7e374f7b56 100644
--- a/x-pack/plugins/watcher/public/application/sections/watch_edit/components/watch_edit.tsx
+++ b/x-pack/plugins/watcher/public/application/sections/watch_edit/components/watch_edit.tsx
@@ -10,19 +10,20 @@ import { isEqual } from 'lodash';
import { EuiPageContent } from '@elastic/eui';
import { i18n } from '@kbn/i18n';
-
import { FormattedMessage } from '@kbn/i18n/react';
-import { Watch } from '../../../models/watch';
+
import { WATCH_TYPES } from '../../../../../common/constants';
import { BaseWatch } from '../../../../../common/types/watch_types';
-import { getPageErrorCode, PageError, SectionLoading, SectionError } from '../../../components';
+import { getPageErrorCode, PageError, SectionLoading } from '../../../components';
import { loadWatch } from '../../../lib/api';
import { listBreadcrumb, editBreadcrumb, createBreadcrumb } from '../../../lib/breadcrumbs';
+import { useAppContext } from '../../../app_context';
+import { Watch } from '../../../models/watch';
+import { PageError as GenericPageError } from '../../../shared_imports';
+import { WatchContext } from '../watch_context';
import { JsonWatchEdit } from './json_watch_edit';
import { ThresholdWatchEdit } from './threshold_watch_edit';
import { MonitoringWatchEdit } from './monitoring_watch_edit';
-import { WatchContext } from '../watch_context';
-import { useAppContext } from '../../../app_context';
const getTitle = (watch: BaseWatch) => {
if (watch.isNew) {
@@ -115,7 +116,7 @@ export const WatchEdit = ({
const loadedWatch = await loadWatch(id);
dispatch({ command: 'setWatch', payload: loadedWatch });
} catch (error) {
- dispatch({ command: 'setError', payload: error });
+ dispatch({ command: 'setError', payload: error.body });
}
} else if (type) {
const WatchType = Watch.getWatchTypes()[type];
@@ -135,36 +136,34 @@ export const WatchEdit = ({
const errorCode = getPageErrorCode(loadError);
if (errorCode) {
return (
-
+
);
- }
-
- if (loadError) {
+ } else if (loadError) {
return (
-
-
- }
- error={loadError}
- />
-
+
+ }
+ error={loadError}
+ />
);
}
if (!watch) {
return (
-
-
-
+
+
+
+
+
);
}
diff --git a/x-pack/plugins/watcher/public/application/sections/watch_list/components/watch_list.tsx b/x-pack/plugins/watcher/public/application/sections/watch_list/components/watch_list.tsx
index 0e89871063507e..31accef0b63691 100644
--- a/x-pack/plugins/watcher/public/application/sections/watch_list/components/watch_list.tsx
+++ b/x-pack/plugins/watcher/public/application/sections/watch_list/components/watch_list.tsx
@@ -11,25 +11,25 @@ import {
CriteriaWithPagination,
EuiButton,
EuiButtonEmpty,
- EuiFlexGroup,
- EuiFlexItem,
EuiInMemoryTable,
EuiLink,
EuiPageContent,
EuiSpacer,
EuiText,
- EuiTitle,
EuiToolTip,
EuiEmptyPrompt,
EuiButtonIcon,
EuiPopover,
EuiContextMenuPanel,
EuiContextMenuItem,
+ EuiPageHeader,
} from '@elastic/eui';
import { i18n } from '@kbn/i18n';
import { FormattedMessage } from '@kbn/i18n/react';
import { Moment } from 'moment';
+import { reactRouterNavigate } from '../../../../../../../../src/plugins/kibana_react/public';
+
import { REFRESH_INTERVALS, PAGINATION, WATCH_TYPES } from '../../../../../common/constants';
import { listBreadcrumb } from '../../../lib/breadcrumbs';
import {
@@ -37,15 +37,13 @@ import {
PageError,
DeleteWatchesModal,
WatchStatus,
- SectionError,
SectionLoading,
Error,
} from '../../../components';
import { useLoadWatches } from '../../../lib/api';
import { goToCreateThresholdAlert, goToCreateAdvancedWatch } from '../../../lib/navigation';
import { useAppContext } from '../../../app_context';
-
-import { reactRouterNavigate } from '../../../../../../../../src/plugins/kibana_react/public';
+import { PageError as GenericPageError } from '../../../shared_imports';
export const WatchList = () => {
// hooks
@@ -173,21 +171,36 @@ export const WatchList = () => {
if (isWatchesLoading) {
return (
-
-
-
+
+
+
+
+
);
}
- if (getPageErrorCode(error)) {
+ const errorCode = getPageErrorCode(error);
+ if (errorCode) {
return (
-
-
+
+
);
+ } else if (error) {
+ return (
+
+ }
+ error={(error as unknown) as Error}
+ />
+ );
}
if (availableWatches && availableWatches.length === 0) {
@@ -206,7 +219,7 @@ export const WatchList = () => {
);
return (
-
+
{
let content;
- if (error) {
- content = (
-
- }
- error={(error as unknown) as Error}
- />
- );
- } else if (availableWatches) {
+ if (availableWatches) {
const columns = [
{
field: 'id',
@@ -463,56 +464,46 @@ export const WatchList = () => {
);
}
- if (content) {
- return (
-
- {
- if (deleted) {
- setDeletedWatches([...deletedWatches, ...watchesToDelete]);
- }
- setWatchesToDelete([]);
- }}
- watchesToDelete={watchesToDelete}
- />
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- {watcherDescriptionText}
-
+ return (
+ <>
+
+
+
+ }
+ bottomBorder
+ rightSideItems={[
+
+
+ ,
+ ]}
+ description={watcherDescriptionText}
+ />
+ {
+ if (deleted) {
+ setDeletedWatches([...deletedWatches, ...watchesToDelete]);
+ }
+ setWatchesToDelete([]);
+ }}
+ watchesToDelete={watchesToDelete}
+ />
-
+
- {content}
-
- );
- }
- return null;
+ {content}
+ >
+ );
};
diff --git a/x-pack/plugins/watcher/public/application/sections/watch_status/components/watch_status.tsx b/x-pack/plugins/watcher/public/application/sections/watch_status/components/watch_status.tsx
index 1e3548620339aa..73400b9ccaaa72 100644
--- a/x-pack/plugins/watcher/public/application/sections/watch_status/components/watch_status.tsx
+++ b/x-pack/plugins/watcher/public/application/sections/watch_status/components/watch_status.tsx
@@ -9,14 +9,10 @@ import React, { useEffect, useState } from 'react';
import {
EuiPageContent,
EuiSpacer,
- EuiTabs,
- EuiTab,
- EuiFlexGroup,
- EuiFlexItem,
- EuiTitle,
EuiToolTip,
EuiBadge,
EuiButtonEmpty,
+ EuiPageHeader,
} from '@elastic/eui';
import { i18n } from '@kbn/i18n';
import { FormattedMessage } from '@kbn/i18n/react';
@@ -88,18 +84,20 @@ export const WatchStatus = ({
if (isWatchDetailLoading) {
return (
-
-
-
+
+
+
+
+
);
}
if (errorCode) {
return (
-
+
);
@@ -156,20 +154,11 @@ export const WatchStatus = ({
return (
-
- {
- if (deleted) {
- goToWatchList();
- }
- setWatchesToDelete([]);
- }}
- watchesToDelete={watchesToDelete}
- />
-
-
-
-
+ <>
+
+
-
-
-
- {isSystemWatch ? (
-
-
- }
- >
-
-
-
-
-
- ) : (
-
-
-
+
+ {isSystemWatch && (
+ <>
+ {' '}
+
+ }
+ >
+
+
+
+
+ >
+ )}
+ >
+ }
+ bottomBorder
+ rightSideItems={
+ isSystemWatch
+ ? []
+ : [
toggleWatchActivation()}
isLoading={isTogglingActivation}
>
{activationButtonText}
-
-
-
+ ,
{
@@ -223,30 +213,34 @@ export const WatchStatus = ({
id="xpack.watcher.sections.watchHistory.deleteWatchButtonLabel"
defaultMessage="Delete"
/>
-
-
-
-
- )}
-
-
-
- {WATCH_STATUS_TABS.map((tab, index) => (
- {
- setSelectedTab(tab.id);
- }}
- isSelected={tab.id === selectedTab}
- key={index}
- data-test-subj="tab"
- >
- {tab.name}
-
- ))}
-
+ ,
+ ]
+ }
+ tabs={WATCH_STATUS_TABS.map((tab, index) => ({
+ onClick: () => {
+ setSelectedTab(tab.id);
+ },
+ isSelected: tab.id === selectedTab,
+ key: index,
+ 'data-test-subj': 'tab',
+ label: tab.name,
+ }))}
+ />
+
+
{selectedTab === WATCH_ACTIONS_TAB ? : }
-
+
+ {
+ if (deleted) {
+ goToWatchList();
+ }
+ setWatchesToDelete([]);
+ }}
+ watchesToDelete={watchesToDelete}
+ />
+ >
);
}
diff --git a/x-pack/plugins/watcher/public/application/shared_imports.ts b/x-pack/plugins/watcher/public/application/shared_imports.ts
index e3eb11eda77b30..44bef3b0c4f5f6 100644
--- a/x-pack/plugins/watcher/public/application/shared_imports.ts
+++ b/x-pack/plugins/watcher/public/application/shared_imports.ts
@@ -12,4 +12,5 @@ export {
sendRequest,
useRequest,
XJson,
+ PageError,
} from '../../../../../src/plugins/es_ui_shared/public';