From 328333d912f31b51890c0d3b1c05d0a505d24d5e Mon Sep 17 00:00:00 2001
From: Robert Oskamp <robert.oskamp@elastic.co>
Date: Tue, 25 Feb 2020 13:14:38 +0100
Subject: [PATCH] [ML] Functional tests - stabilize typing during df analytics
 creation (#58227) (#58442)

This PR makes the typing in data frame analytics tests more robust.
---
 .../data_frame_analytics_creation.ts          | 24 ++++++++++++-------
 x-pack/test/functional/services/ml.ts         |  5 +++-
 2 files changed, 19 insertions(+), 10 deletions(-)

diff --git a/x-pack/test/functional/services/machine_learning/data_frame_analytics_creation.ts b/x-pack/test/functional/services/machine_learning/data_frame_analytics_creation.ts
index b4e455ebaa63fd..96dc8993c3d35e 100644
--- a/x-pack/test/functional/services/machine_learning/data_frame_analytics_creation.ts
+++ b/x-pack/test/functional/services/machine_learning/data_frame_analytics_creation.ts
@@ -6,10 +6,12 @@
 import expect from '@kbn/expect';
 
 import { FtrProviderContext } from '../../ftr_provider_context';
+import { MlCommon } from './common';
 
-export function MachineLearningDataFrameAnalyticsCreationProvider({
-  getService,
-}: FtrProviderContext) {
+export function MachineLearningDataFrameAnalyticsCreationProvider(
+  { getService }: FtrProviderContext,
+  mlCommon: MlCommon
+) {
   const testSubjects = getService('testSubjects');
   const comboBox = getService('comboBox');
   const retry = getService('retry');
@@ -85,14 +87,14 @@ export function MachineLearningDataFrameAnalyticsCreationProvider({
     },
 
     async setJobId(jobId: string) {
-      await testSubjects.setValue('mlAnalyticsCreateJobFlyoutJobIdInput', jobId, {
+      await mlCommon.setValueWithChecks('mlAnalyticsCreateJobFlyoutJobIdInput', jobId, {
         clearWithKeyboard: true,
       });
       await this.assertJobIdValue(jobId);
     },
 
     async setJobDescription(jobDescription: string) {
-      await testSubjects.setValue('mlDFAnalyticsJobCreationJobDescription', jobDescription, {
+      await mlCommon.setValueWithChecks('mlDFAnalyticsJobCreationJobDescription', jobDescription, {
         clearWithKeyboard: true,
       });
       await this.assertJobDescriptionValue(jobDescription);
@@ -136,9 +138,13 @@ export function MachineLearningDataFrameAnalyticsCreationProvider({
     },
 
     async setDestIndex(destIndex: string) {
-      await testSubjects.setValue('mlAnalyticsCreateJobFlyoutDestinationIndexInput', destIndex, {
-        clearWithKeyboard: true,
-      });
+      await mlCommon.setValueWithChecks(
+        'mlAnalyticsCreateJobFlyoutDestinationIndexInput',
+        destIndex,
+        {
+          clearWithKeyboard: true,
+        }
+      );
       await this.assertDestIndexValue(destIndex);
     },
 
@@ -248,7 +254,7 @@ export function MachineLearningDataFrameAnalyticsCreationProvider({
     },
 
     async setModelMemory(modelMemory: string) {
-      await testSubjects.setValue('mlAnalyticsCreateJobFlyoutModelMemoryInput', modelMemory, {
+      await mlCommon.setValueWithChecks('mlAnalyticsCreateJobFlyoutModelMemoryInput', modelMemory, {
         clearWithKeyboard: true,
       });
       await this.assertModelMemoryValue(modelMemory);
diff --git a/x-pack/test/functional/services/ml.ts b/x-pack/test/functional/services/ml.ts
index 2660a90662dec3..354e0907375ca4 100644
--- a/x-pack/test/functional/services/ml.ts
+++ b/x-pack/test/functional/services/ml.ts
@@ -42,7 +42,10 @@ export function MachineLearningProvider(context: FtrProviderContext) {
   const api = MachineLearningAPIProvider(context);
   const customUrls = MachineLearningCustomUrlsProvider(context);
   const dataFrameAnalytics = MachineLearningDataFrameAnalyticsProvider(context, api);
-  const dataFrameAnalyticsCreation = MachineLearningDataFrameAnalyticsCreationProvider(context);
+  const dataFrameAnalyticsCreation = MachineLearningDataFrameAnalyticsCreationProvider(
+    context,
+    common
+  );
   const dataFrameAnalyticsTable = MachineLearningDataFrameAnalyticsTableProvider(context);
   const dataVisualizer = MachineLearningDataVisualizerProvider(context);
   const dataVisualizerIndexBased = MachineLearningDataVisualizerIndexBasedProvider(context);