From 26e092fbb3cfdb48635ecc94e1e25bbddee98af1 Mon Sep 17 00:00:00 2001 From: Alexey Antonov Date: Mon, 12 Aug 2019 14:50:37 +0300 Subject: [PATCH] [Top Nav] Date picker not correctly positioned in TSVB visualization --- .../query/query_bar/components/query_bar.tsx | 7 +- .../public/top_nav_menu/top_nav_menu.tsx | 90 +++++++++++-------- 2 files changed, 58 insertions(+), 39 deletions(-) diff --git a/src/legacy/core_plugins/data/public/query/query_bar/components/query_bar.tsx b/src/legacy/core_plugins/data/public/query/query_bar/components/query_bar.tsx index ab549896b5824bb..d790e07ee678b70 100644 --- a/src/legacy/core_plugins/data/public/query/query_bar/components/query_bar.tsx +++ b/src/legacy/core_plugins/data/public/query/query_bar/components/query_bar.tsx @@ -266,7 +266,12 @@ export class QueryBarUI extends Component { }); return ( - + {this.renderQueryInput()} {this.renderUpdateButton()} diff --git a/src/legacy/core_plugins/kibana_react/public/top_nav_menu/top_nav_menu.tsx b/src/legacy/core_plugins/kibana_react/public/top_nav_menu/top_nav_menu.tsx index 6b1c207982873c8..9c125b23c6c630d 100644 --- a/src/legacy/core_plugins/kibana_react/public/top_nav_menu/top_nav_menu.tsx +++ b/src/legacy/core_plugins/kibana_react/public/top_nav_menu/top_nav_menu.tsx @@ -44,58 +44,72 @@ type Props = Partial & { export function TopNavMenu(props: Props) { function renderItems() { - if (!props.config) return; - return props.config.map((menuItem: TopNavMenuData, i: number) => { - return ( - - - - ); - }); + if (!props.config) { + return null; + } + + return ( + + {props.config.map((menuItem: TopNavMenuData, i: number) => { + return ( + + + + ); + })} + + ); } function renderSearchBar() { // Validate presense of all required fields - if (!props.showSearchBar) return; + if (!props.showSearchBar) { + return null; + } return ( - + + + ); } function renderLayout() { + const direction = props.showSearchBar && props.showFilterBar ? 'column' : 'row'; + return ( - + {renderItems()} + {renderSearchBar()} - {renderSearchBar()} ); }