[Top Nav] Date picker not correctly positioned in TSVB visualization

elastic · Aug 12, 2019 · 26e092f · 26e092f
1 parent 44f26d5
commit 26e092f
Show file tree

Hide file tree

Showing 2 changed files with 58 additions and 39 deletions.
diff --git a/src/legacy/core_plugins/data/public/query/query_bar/components/query_bar.tsx b/src/legacy/core_plugins/data/public/query/query_bar/components/query_bar.tsx
@@ -266,7 +266,12 @@ export class QueryBarUI extends Component<Props, State> {
     });
 
     return (
-      <EuiFlexGroup className={classes} responsive={!!this.props.showDatePicker} gutterSize="s">
+      <EuiFlexGroup
+        className={classes}
+        responsive={!!this.props.showDatePicker}
+        gutterSize="s"
+        justifyContent={'flexEnd'}
+      >
         {this.renderQueryInput()}
         <EuiFlexItem grow={false}>{this.renderUpdateButton()}</EuiFlexItem>
       </EuiFlexGroup>

diff --git a/src/legacy/core_plugins/kibana_react/public/top_nav_menu/top_nav_menu.tsx b/src/legacy/core_plugins/kibana_react/public/top_nav_menu/top_nav_menu.tsx
@@ -44,58 +44,72 @@ type Props = Partial<SearchBarProps> & {
 
 export function TopNavMenu(props: Props) {
   function renderItems() {
-    if (!props.config) return;
-    return props.config.map((menuItem: TopNavMenuData, i: number) => {
-      return (
-        <EuiFlexItem grow={false} key={`nav-menu-${i}`}>
-          <TopNavMenuItem {...menuItem} />
-        </EuiFlexItem>
-      );
-    });
+    if (!props.config) {
+      return null;
+    }
+
+    return (
+      <EuiFlexGroup
+        alignItems="left"
+        data-test-subj="top-nav"
+        justifyContent="flexStart"
+        className="kbnTopNavMenu"
+        grow={false}
+        responsive={false}
+      >
+        {props.config.map((menuItem: TopNavMenuData, i: number) => {
+          return (
+            <EuiFlexItem grow={false} key={`nav-menu-${i}`}>
+              <TopNavMenuItem {...menuItem} />
+            </EuiFlexItem>
+          );
+        })}
+      </EuiFlexGroup>
+    );
   }
 
   function renderSearchBar() {
     // Validate presense of all required fields
-    if (!props.showSearchBar) return;
+    if (!props.showSearchBar) {
+      return null;
+    }
 
     return (
-      <SearchBar
-        query={props.query}
-        filters={props.filters}
-        uiSettings={props.uiSettings}
-        showQueryBar={props.showQueryBar}
-        showQueryInput={props.showQueryInput}
-        showFilterBar={props.showFilterBar}
-        showDatePicker={props.showDatePicker}
-        appName={props.appName!}
-        screenTitle={props.screenTitle!}
-        onQuerySubmit={props.onQuerySubmit}
-        onFiltersUpdated={props.onFiltersUpdated}
-        dateRangeFrom={props.dateRangeFrom}
-        dateRangeTo={props.dateRangeTo}
-        isRefreshPaused={props.isRefreshPaused}
-        showAutoRefreshOnly={props.showAutoRefreshOnly}
-        onRefreshChange={props.onRefreshChange}
-        refreshInterval={props.refreshInterval}
-        indexPatterns={props.indexPatterns}
-        store={props.store}
-      />
+      <EuiFlexItem grow={true}>
+        <SearchBar
+          query={props.query}
+          filters={props.filters}
+          uiSettings={props.uiSettings}
+          showQueryBar={props.showQueryBar}
+          showQueryInput={props.showQueryInput}
+          showFilterBar={props.showFilterBar}
+          showDatePicker={props.showDatePicker}
+          appName={props.appName!}
+          screenTitle={props.screenTitle!}
+          onQuerySubmit={props.onQuerySubmit}
+          onFiltersUpdated={props.onFiltersUpdated}
+          dateRangeFrom={props.dateRangeFrom}
+          dateRangeTo={props.dateRangeTo}
+          isRefreshPaused={props.isRefreshPaused}
+          showAutoRefreshOnly={props.showAutoRefreshOnly}
+          onRefreshChange={props.onRefreshChange}
+          refreshInterval={props.refreshInterval}
+          indexPatterns={props.indexPatterns}
+          store={props.store}
+        />
+      </EuiFlexItem>
     );
   }
 
   function renderLayout() {
+    const direction = props.showSearchBar && props.showFilterBar ? 'column' : 'row';
+
     return (
       <span className="kbnTopNavMenu__wrapper">
-        <EuiFlexGroup
-          data-test-subj="top-nav"
-          justifyContent="flexStart"
-          gutterSize="none"
-          className="kbnTopNavMenu"
-          responsive={false}
-        >
+        <EuiFlexGroup gutterSize="none" direction={direction}>
           {renderItems()}
+          {renderSearchBar()}
         </EuiFlexGroup>
-        {renderSearchBar()}
       </span>
     );
   }