From 05e527ca90a69a7a20508e3f00913f148900f685 Mon Sep 17 00:00:00 2001
From: iblancof <irene.blanco@elastic.co>
Date: Fri, 25 Oct 2024 12:31:24 +0200
Subject: [PATCH] Rename some constants

---
 .../add_data_context_menu.tsx                 | 16 ++++++------
 .../shared/add_data_buttons/buttons.tsx       | 26 +++++++++----------
 2 files changed, 21 insertions(+), 21 deletions(-)

diff --git a/x-pack/plugins/observability_solution/apm/public/components/routing/app_root/apm_header_action_menu/add_data_context_menu.tsx b/x-pack/plugins/observability_solution/apm/public/components/routing/app_root/apm_header_action_menu/add_data_context_menu.tsx
index 3e2281b26fc87..0b628ff985735 100644
--- a/x-pack/plugins/observability_solution/apm/public/components/routing/app_root/apm_header_action_menu/add_data_context_menu.tsx
+++ b/x-pack/plugins/observability_solution/apm/public/components/routing/app_root/apm_header_action_menu/add_data_context_menu.tsx
@@ -20,9 +20,9 @@ import { useKibana } from '../../../../context/kibana_context/use_kibana';
 import { ApmPluginStartDeps, ApmServices } from '../../../../plugin';
 import { EntityInventoryAddDataParams } from '../../../../services/telemetry';
 import {
-  associateServiceLogs,
-  collectServiceLogs,
-  addApmData,
+  associateServiceLogsProps,
+  collectServiceLogsProps,
+  addApmDataProps,
 } from '../../../shared/add_data_buttons/buttons';
 
 const addData = i18n.translate('xpack.apm.addDataContextMenu.link', {
@@ -45,7 +45,7 @@ export function AddDataContextMenu() {
     OBSERVABILITY_ONBOARDING_LOCATOR
   );
 
-  const addApmButtonData = addApmData(onboardingLocator);
+  const addApmButtonData = addApmDataProps(onboardingLocator);
 
   const button = (
     <EuiHeaderLink
@@ -72,8 +72,8 @@ export function AddDataContextMenu() {
       title: addData,
       items: [
         {
-          name: associateServiceLogs.name,
-          href: associateServiceLogs.link,
+          name: associateServiceLogsProps.name,
+          href: associateServiceLogsProps.link,
           'data-test-subj': 'apmAddDataAssociateServiceLogs',
           target: '_blank',
           onClick: () => {
@@ -81,8 +81,8 @@ export function AddDataContextMenu() {
           },
         },
         {
-          name: collectServiceLogs.name,
-          href: basePath.prepend(collectServiceLogs.link),
+          name: collectServiceLogsProps.name,
+          href: basePath.prepend(collectServiceLogsProps.link),
           'data-test-subj': 'apmAddDataCollectServiceLogs',
           onClick: () => {
             reportButtonClick('collect_new_service_logs');
diff --git a/x-pack/plugins/observability_solution/apm/public/components/shared/add_data_buttons/buttons.tsx b/x-pack/plugins/observability_solution/apm/public/components/shared/add_data_buttons/buttons.tsx
index d56d9a685da7d..b58799f0e00c2 100644
--- a/x-pack/plugins/observability_solution/apm/public/components/shared/add_data_buttons/buttons.tsx
+++ b/x-pack/plugins/observability_solution/apm/public/components/shared/add_data_buttons/buttons.tsx
@@ -19,7 +19,7 @@ import {
   ApmOnboardingLocatorParams,
 } from '../../../locator/onboarding_locator';
 
-export const addApmData = (locator: LocatorPublic<ApmOnboardingLocatorParams> | undefined) => {
+export const addApmDataProps = (locator: LocatorPublic<ApmOnboardingLocatorParams> | undefined) => {
   return {
     name: i18n.translate('xpack.apm.add.apm.agent.button.', {
       defaultMessage: 'Add APM',
@@ -28,14 +28,14 @@ export const addApmData = (locator: LocatorPublic<ApmOnboardingLocatorParams> |
   };
 };
 
-export const associateServiceLogs = {
+export const associateServiceLogsProps = {
   name: i18n.translate('xpack.apm.associate.service.logs.button', {
     defaultMessage: 'Associate existing service logs',
   }),
   link: 'https://ela.st/new-experience-associate-service-logs',
 };
 
-export const collectServiceLogs = {
+export const collectServiceLogsProps = {
   name: i18n.translate('xpack.apm.collect.service.logs.button', {
     defaultMessage: 'Collect new service logs',
   }),
@@ -60,9 +60,9 @@ export function AddApmData({ fill = false, size = 's', ...props }: AddApmDataPro
     OBSERVABILITY_ONBOARDING_LOCATOR
   );
 
-  const addApmButtonData = addApmData(onboardingLocator);
+  const addApmDataButtonProps = addApmDataProps(onboardingLocator);
 
-  if (!addApmButtonData.link) {
+  if (!addApmDataButtonProps.link) {
     return;
   }
 
@@ -71,10 +71,10 @@ export function AddApmData({ fill = false, size = 's', ...props }: AddApmDataPro
       data-test-subj={props['data-test-subj']}
       size={size}
       onClick={props.onClick}
-      href={addApmButtonData?.link}
+      href={addApmDataButtonProps?.link}
       fill={fill}
     >
-      {addApmButtonData.name}
+      {addApmDataButtonProps.name}
     </EuiButton>
   );
 }
@@ -82,15 +82,15 @@ export function AddApmData({ fill = false, size = 's', ...props }: AddApmDataPro
 export function AssociateServiceLogs({ onClick }: { onClick?: () => void }) {
   return (
     <EuiButton
-      data-test-subj="associateServiceLogsButton"
+      data-test-subj="associateServiceLogsPropsButton"
       size="s"
       onClick={onClick}
-      href={associateServiceLogs.link}
+      href={associateServiceLogsProps.link}
       target="_blank"
       iconType="popout"
       iconSide="right"
     >
-      {associateServiceLogs.name}
+      {associateServiceLogsProps.name}
     </EuiButton>
   );
 }
@@ -101,12 +101,12 @@ export function CollectServiceLogs({ onClick }: { onClick?: () => void }) {
 
   return (
     <EuiButton
-      data-test-subj="collectServiceLogsButton"
+      data-test-subj="collectServiceLogsPropsButton"
       size="s"
       onClick={onClick}
-      href={basePath.prepend(collectServiceLogs.link)}
+      href={basePath.prepend(collectServiceLogsProps.link)}
     >
-      {collectServiceLogs.name}
+      {collectServiceLogsProps.name}
     </EuiButton>
   );
 }