From 04d959431d456a082666bf7834f129f1aafd0772 Mon Sep 17 00:00:00 2001 From: restrry Date: Tue, 9 Jun 2020 20:10:51 +0200 Subject: [PATCH] disable new babel plugins --- .../kbn-babel-preset/common_babel_parser_options.js | 6 +++--- packages/kbn-babel-preset/common_preset.js | 12 ++++++------ src/core/server/server.ts | 6 +++--- src/dev/i18n/extractors/code.js | 6 +++--- 4 files changed, 15 insertions(+), 15 deletions(-) diff --git a/packages/kbn-babel-preset/common_babel_parser_options.js b/packages/kbn-babel-preset/common_babel_parser_options.js index eec31329d96bec..79c5571798f60f 100644 --- a/packages/kbn-babel-preset/common_babel_parser_options.js +++ b/packages/kbn-babel-preset/common_babel_parser_options.js @@ -24,11 +24,11 @@ module.exports = { plugins: [ 'asyncGenerators', 'classProperties', - 'classPrivateProperties', - 'classPrivateMethods', + // 'classPrivateProperties', + // 'classPrivateMethods', 'dynamicImport', 'exportDefaultFrom', - 'exportNamespaceFrom', + // 'exportNamespaceFrom', 'objectRestSpread', 'throwExpressions', ], diff --git a/packages/kbn-babel-preset/common_preset.js b/packages/kbn-babel-preset/common_preset.js index 8e2f1d207f3f41..1033c8aa6b91e5 100644 --- a/packages/kbn-babel-preset/common_preset.js +++ b/packages/kbn-babel-preset/common_preset.js @@ -35,13 +35,13 @@ const plugins = [ // Need this since we are using TypeScript 3.7+ require.resolve('@babel/plugin-proposal-nullish-coalescing-operator'), - // Proposal is on stage 4 (https://github.com/tc39/proposal-export-ns-from) - // Need this since we are using TypeScript 3.8+ - require.resolve('@babel/plugin-proposal-export-namespace-from'), + // // Proposal is on stage 4 (https://github.com/tc39/proposal-export-ns-from) + // // Need this since we are using TypeScript 3.8+ + // require.resolve('@babel/plugin-proposal-export-namespace-from'), - // Proposal is on stage 4 (https://github.com/tc39/proposal-export-ns-from) - // Need this since we are using TypeScript 3.9+ - require.resolve('@babel/plugin-proposal-private-methods'), + // // Proposal is on stage 4 (https://github.com/tc39/proposal-export-ns-from) + // // Need this since we are using TypeScript 3.9+ + // require.resolve('@babel/plugin-proposal-private-methods'), ]; module.exports = { diff --git a/src/core/server/server.ts b/src/core/server/server.ts index 6ca580083648f8..ef12379c199e8c 100644 --- a/src/core/server/server.ts +++ b/src/core/server/server.ts @@ -76,7 +76,7 @@ export class Server { private readonly status: StatusService; private readonly coreApp: CoreApp; - #pluginsInitialized?: boolean; + private pluginsInitialized?: boolean; private coreStart?: InternalCoreStart; constructor( @@ -179,7 +179,7 @@ export class Server { }; const pluginsSetup = await this.plugins.setup(coreSetup); - this.#pluginsInitialized = pluginsSetup.initialized; + this.pluginsInitialized = pluginsSetup.initialized; await this.legacy.setup({ core: { ...coreSetup, plugins: pluginsSetup, rendering: renderingSetup }, @@ -198,7 +198,7 @@ export class Server { const elasticsearchStart = await this.elasticsearch.start(); const savedObjectsStart = await this.savedObjects.start({ elasticsearch: elasticsearchStart, - pluginsInitialized: this.#pluginsInitialized, + pluginsInitialized: this.pluginsInitialized, }); const capabilitiesStart = this.capabilities.start(); const uiSettingsStart = await this.uiSettings.start(); diff --git a/src/dev/i18n/extractors/code.js b/src/dev/i18n/extractors/code.js index 71f28a36e6e849..614b886891dfa9 100644 --- a/src/dev/i18n/extractors/code.js +++ b/src/dev/i18n/extractors/code.js @@ -72,13 +72,13 @@ export function* extractCodeMessages(buffer, reporter) { 'typescript', 'objectRestSpread', 'classProperties', - 'classPrivateProperties', - 'classPrivateMethods', + // 'classPrivateProperties', + // 'classPrivateMethods', 'asyncGenerators', 'dynamicImport', 'nullishCoalescingOperator', 'optionalChaining', - 'exportNamespaceFrom', + // 'exportNamespaceFrom', ], }); } catch (error) {