Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCP Carbon Footprint integration #5566

Closed
wants to merge 5 commits into from
Closed

GCP Carbon Footprint integration #5566

wants to merge 5 commits into from

Conversation

dmathieu
Copy link
Member

What does this PR do?

This adds a new integration, for GCP Carbon Footprint.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

How to test this PR locally

Use elastic-package with beats running on a version where the new metricset is available.

Related issues

Screenshots

@dmathieu dmathieu added the enhancement New feature or request label Mar 16, 2023
@elasticmachine
Copy link

elasticmachine commented Mar 16, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-06T15:00:06.832+0000

  • Duration: 18 min 1 sec

Test stats 🧪

Test Results
Failed 0
Passed 61
Skipped 0
Total 61

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Mar 16, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (6/6) 💚
Files 100.0% (6/6) 💚 6.25
Classes 100.0% (6/6) 💚 6.25
Methods 88.991% (97/109) 👍 3.07
Lines 96.0% (1464/1525) 👍 10.075
Conditionals 100.0% (0/0) 💚

@endorama endorama added Integration:gcp Google Cloud Platform Team:Cloud-Monitoring Label for the Cloud Monitoring team labels Mar 16, 2023
Copy link
Member

@endorama endorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small change, as the PR link in changelog is not correct :)

Co-authored-by: Edoardo Tenani <526307+endorama@users.noreply.github.com>
@botelastic
Copy link

botelastic bot commented Apr 19, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Apr 19, 2023
@dmathieu
Copy link
Member Author

I will pick this up again once 8.8.0 is released and the related beats change is released.

@botelastic botelastic bot removed the Stalled label Apr 19, 2023
@botelastic
Copy link

botelastic bot commented May 19, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label May 19, 2023
@botelastic botelastic bot removed the Stalled label May 22, 2023
@botelastic
Copy link

botelastic bot commented Jul 6, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Jul 6, 2023
@botelastic
Copy link

botelastic bot commented Aug 5, 2023

Hi! This PR has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this PR if you think it should stay open and is worth rebasing. Thank you for your contribution!

@botelastic botelastic bot closed this Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:gcp Google Cloud Platform Stalled Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collect Google Cloud Carbon Footprint
3 participants