Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message is displayed to user, when user is trying to add AWS integrations to agent policies. #6088

Closed
dikshachauhan-qasource opened this issue May 4, 2023 · 12 comments
Assignees
Labels
bug Something isn't working, use only for issues impact:high Short-term priority; add to current release, or definitely next. QA:Validated Validated by the QA Team Team:Fleet Label for the Fleet team [elastic/fleet]

Comments

@dikshachauhan-qasource
Copy link

dikshachauhan-qasource commented May 4, 2023

Kibana version: 8.8.0 BC2 staging Kibana cloud environment

Host OS: Windows
Browser: Chrome

Build details:
VERSION: 8.8.0 BC2
BUILD: 62857
COMMIT: 33efd47ee6927b54b328e901fe31d31eae875325
Artifact: https://staging.elastic.co/8.8.0-118443e6/summary-8.8.0.html

Preconditions:

  • 8.8.0 BC2 staging Kibana cloud environment should be available.

Steps to reproduce:

  • Navigate to Fleet > Policies Tab.
  • Using "Add integration" button on Policy detail page attempt to add "AWS DynamoDB" integration.
  • Observe Error message is displayed.

Screenshots:
image
image

Expected Result:

  • No error message should be displayed to user, when user is trying to add AWS integrations.
@dikshachauhan-qasource dikshachauhan-qasource added bug Something isn't working, use only for issues Team:Integrations Label for the Integrations team impact:high Short-term priority; add to current release, or definitely next. labels May 4, 2023
@elasticmachine
Copy link

Pinging @elastic/integrations (Team:Integrations)

@manishgupta-qasource
Copy link

Reviewed & assigned to @kpollich

@dikshachauhan-qasource dikshachauhan-qasource changed the title Error message should be displayed to user, when user is trying to add AWS integrations to agent policies. Error message is displayed to user, when user is trying to add AWS integrations to agent policies. May 4, 2023
@jen-huang
Copy link
Contributor

jen-huang commented May 4, 2023

(Wrong issue, sorry for the pings!)

@jen-huang jen-huang assigned efd6 and unassigned efd6 May 4, 2023
@jen-huang
Copy link
Contributor

Full error:

{
    "statusCode": 500,
    "error": "Internal Server Error",
    "message": "Error installing aws 1.34.3: Encountered 1 errors creating saved objects: [{\"type\":\"search\",\"id\":\"aws-30ccde50-7397-11ea-a345-f985c61fe654\",\"error\":{\"isBoom\":true,\"isServer\":false,\"data\":null,\"output\":{\"statusCode\":400,\"payload\":{\"message\":\"[attributes.sort]: types that failed validation:\\n- [attributes.sort.0.0]: array size is [0], but cannot be smaller than [2]\\n- [attributes.sort.1.0]: expected value of type [string] but got [Array]: Bad Request\",\"statusCode\":400,\"error\":\"Bad Request\"},\"headers\":{}},\"type\":\"unknown\"}}]"
}

It is failing to install this saved search asset which hasn't been touched in a few years.

Investigating to see if changes in elastic/kibana#154016, which added stricter schema validation for sort field may be the culprit...

@jen-huang
Copy link
Contributor

jen-huang commented May 4, 2023

@davismcphee I believe the change above is causing the saved objects importer to reject sort: [] on this saved search object. Would it be possible to adjust the schema to allow an empty array here for BWC?

I confirmed that there are no issues with importing this object in 8.7.1, only 8.8.0.

@jen-huang jen-huang assigned jen-huang and unassigned kpollich May 4, 2023
@jen-huang jen-huang added Team:Fleet Label for the Fleet team [elastic/fleet] and removed Team:Integrations Label for the Integrations team labels May 4, 2023
@elasticmachine
Copy link

Pinging @elastic/fleet (Team:Fleet)

@davismcphee
Copy link

@jen-huang This was definitely caused by elastic/kibana#154016 and was an oversight on my part -- empty sort arrays are a valid scenario for saved searches. I've opened elastic/kibana#156724 to track the bug in the Kibana repo and will publish a PR asap to get the schema fixed.

@davismcphee
Copy link

@jen-huang Just an update that the PR for elastic/kibana#156724 has been merged now and backported to 8.8, so the issue should be fixed.

@jen-huang
Copy link
Contributor

Thanks @davismcphee!

@dikshachauhan-qasource please validate the fix on the next BC. Thanks!

@amolnater-qasource amolnater-qasource added the QA:Needs Validation Needs validation by the QA Team label May 7, 2023
@dikshachauhan-qasource dikshachauhan-qasource added QA:Needs Validation Needs validation by the QA Team and removed QA:Needs Validation Needs validation by the QA Team labels May 8, 2023
@dikshachauhan-qasource
Copy link
Author

Hi @jen-huang

Thanks for the update, we will revalidate this issue on BC3.

Thanks.

@dikshachauhan-qasource
Copy link
Author

Hi @jen-huang

We have revalidated this issue on latest 8.8.0 BC3 Kibana staging cloud build and found it working fine.

Observation:

  • User is now able to add the AWS integrations successfully to the agent policies.

Build details:

VERSION: 8.8.0
BUILD: 62994
COMMIT: 85b22d307ab93fca95c1698ede4cb61d85f3d314

Screenshot:
image

Hence, we are marking it as "QA:Validated".

Thanks!!

@dikshachauhan-qasource dikshachauhan-qasource removed the QA:Needs Validation Needs validation by the QA Team label May 11, 2023
@dikshachauhan-qasource dikshachauhan-qasource added the QA:Validated Validated by the QA Team label May 11, 2023
@harshitgupta-qasource
Copy link

Bug Conversion:

We have updated 01 testcase for this scenario in our fleet test suite at:

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues impact:high Short-term priority; add to current release, or definitely next. QA:Validated Validated by the QA Team Team:Fleet Label for the Fleet team [elastic/fleet]
Projects
None yet
Development

No branches or pull requests

9 participants