Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Kubernetes integration #511

Closed
8 tasks done
masci opened this issue Jan 12, 2021 · 6 comments
Closed
8 tasks done

Migrate Kubernetes integration #511

masci opened this issue Jan 12, 2021 · 6 comments
Assignees
Labels
fleet-migration Used to track the migration to the new experience Integration:kubernetes Kubernetes release-pending Team:Integrations Label for the Integrations team

Comments

@masci
Copy link
Contributor

masci commented Jan 12, 2021

Integration release checklist

This checklist is intended for integrations maintainers to ensure consistency
when creating or updating a Package, Module or Dataset for an Integration.

All changes

Migration Assessment: https://github.com/elastic/obs-dc-team/blob/master/migration/packages/kubernetes.md

@masci masci added release-pending Integration:kubernetes Kubernetes Team:Integrations Label for the Integrations team labels Jan 12, 2021
@elasticmachine
Copy link

Pinging @elastic/integrations (Team:Integrations)

@ChrsMark
Copy link
Member

Just to note that the testing/CI support for this is not yet landed: elastic/elastic-package#89

@pguan-phl
Copy link

pguan-phl commented Jan 14, 2021

Not sure if it's proper to post it here, just want to mention that I see this there's a complete example manifest available in <<TODO: link to the proper page here>> document. in the Kubernetes integration page (v 7.10.1), and in the README
Guess it's too minor to have a separate ticket, so I'm just reporting here. I know it's still experimental, but if the above TODO is fulfilled it would be great.

Also BTW, can I ask is v8.0.0 the minimal version to use this integration? Cause I see this 8.0.0-SNAPSHOT from this file: https://github.com/elastic/integrations/blob/master/testing/environments/kubernetes/agent.yml . I'm asking because my es-stack is v7.10.1 and I don't have a clue whether to downgrade to use elastic-agent:7.x or upgrade the whole stack.

@ChrsMark
Copy link
Member

@pguan-phl thank's for reporting this one! I have updated the package at #528 to point to the current manifest file.

Regarding versions, you can use an elastic-agent:7.x if you want since the testing files you pointed are just for testing/reference and are not tightly coupled with specific versions.

@ChrsMark
Copy link
Member

ChrsMark commented Feb 9, 2021

Tested manually combining latest version of package and Elastic-Agent-Standalone. After #680 is merged I think we can consider migration as done, close this issue, and keep track of further improvements/work at #601, @masci are you ok with this?

@masci
Copy link
Contributor Author

masci commented Feb 9, 2021

Agree, if you tested #680 let's close this when it gets merged. Thanks @ChrsMark !

@ChrsMark ChrsMark closed this as completed Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fleet-migration Used to track the migration to the new experience Integration:kubernetes Kubernetes release-pending Team:Integrations Label for the Integrations team
Projects
None yet
Development

No branches or pull requests

4 participants