Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudflare Integration - not able to set passwords using double-quotes #3388

Closed
StephanBenning opened this issue May 19, 2022 · 5 comments
Closed
Assignees
Labels
bug Something isn't working, use only for issues Integration:cloudflare Cloudflare

Comments

@StephanBenning
Copy link

When setting a password with double-quotes _blah"blah"blah_ in the Cloudflare audit logs integration the validation is failing with next error:

grafik

It looks there is no proper way to escape string in Fleet template currently, possible fix by using the yaml tag !!str in the integration agent template with something like next:

- value: !!str {{auth_key}}
+ value: "{{auth_key}}"

Related to https://github.com/elastic/integrations/blob/main/packages/cloudflare/data_stream/audit/agent/stream/httpjson.yml.hbs

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@jamiehynds jamiehynds added bug Something isn't working, use only for issues Integration:cloudflare Cloudflare labels May 19, 2022
@nchaulet
Copy link
Member

In this case I think !!str should work but it could still be nice to have an helper in Fleet for that elastic/kibana#127268

@legoguy1000
Copy link
Contributor

I would probably not highlight this as a cloudflare integration issue as I would assume every integration would be affected by this.

@andrewkroh
Copy link
Member

andrewkroh commented Apr 5, 2023

If this hasn't already been fixed then the template should be updated to use the escape_string handlebars function that was added to Fleet.

value: {{escape_string auth_key}}

https://github.com/elastic/kibana/blob/277201e7e2c1a55c67cfd2cb1b3b1ca3baa72ccb/x-pack/plugins/fleet/server/services/epm/agent/agent.ts#L113-L120

@efd6
Copy link
Contributor

efd6 commented Apr 18, 2023

This should be fixed by #5805.

@StephanBenning please confirm that an upgrade to v2.5.1 of the package resolves the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues Integration:cloudflare Cloudflare
Projects
None yet
Development

No branches or pull requests

8 participants