From dc2565e977d9d55c06388c7c8c2dcbdd160b33d1 Mon Sep 17 00:00:00 2001 From: Chandler Prall Date: Wed, 25 Sep 2019 12:44:48 -0600 Subject: [PATCH 1/2] Make EuiTableRowCell textOnly={false} when its an expanded row --- .../basic_table/__snapshots__/basic_table.test.js.snap | 1 + src/components/basic_table/basic_table.js | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/components/basic_table/__snapshots__/basic_table.test.js.snap b/src/components/basic_table/__snapshots__/basic_table.test.js.snap index 054b85bca2e..3f0ab18c62a 100644 --- a/src/components/basic_table/__snapshots__/basic_table.test.js.snap +++ b/src/components/basic_table/__snapshots__/basic_table.test.js.snap @@ -1040,6 +1040,7 @@ exports[`EuiBasicTable itemIdToExpandedRowMap renders an expanded row 1`] = ` >
Expanded row diff --git a/src/components/basic_table/basic_table.js b/src/components/basic_table/basic_table.js index 280f1536cea..f50a7430c4c 100644 --- a/src/components/basic_table/basic_table.js +++ b/src/components/basic_table/basic_table.js @@ -801,7 +801,7 @@ export class EuiBasicTable extends Component { id={expandedRowId} isExpandedRow={true} isSelectable={isSelectable}> - + {itemIdToExpandedRowMap[itemId]} From 528f999631adbd248a99fc2c274a9aca3c2ff214 Mon Sep 17 00:00:00 2001 From: Chandler Prall Date: Wed, 25 Sep 2019 12:48:00 -0600 Subject: [PATCH 2/2] changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0ddfd10a340..5f7a296c8b8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,7 @@ - Added a `showMaxPopover` option for `EuiBreadcrumbs` to display all items when a `max` is set. ([#2342](https://github.com/elastic/eui/pull/2342)) - Added `data-test-subj` support for basic and in-memory tables' actions ([#2353](https://github.com/elastic/eui/pull/2353)) - Added `ip` icon to glyph set ([#2371](https://github.com/elastic/eui/pull/2371)) +- Set `textOnly={true}` for expanded rows in `EuiBasicTable` ([#2376](https://github.com/elastic/eui/pull/2376)) **Bug fixes**