-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiModal] Adjust the source order to announce EuiTitle
before Close button
#7222
Comments
Hi |
@Kaggrov We do not assign non-Elastic team members to issues. Assume that any non-security issue that does not have someone assigned is open to work on and that we'll generally take a PR for it. Please read out contributing wiki for more guidance: https://github.com/elastic/eui/tree/main/wiki/contributing-to-eui#who-can-contribute |
👋 Hi there - this issue hasn't had any activity in 6 months. If the EUI team has not explicitly expressed that this is something on our roadmap, it's unlikely that we'll pick this issue up. We would sincerely appreciate a PR/community contribution if this is something that matters to you! If not, and there is no further activity on this issue for another 6 months (i.e. it's stale for over a year), the issue will be auto-closed. |
Describe the problem
@kyrspl && @cee-chen are making a dismiss (close) button to
EuiCallout
in #7156. They proposed moving the heading (title) before the dismiss button in the source order so screen reader users could hear the message heading before deciding to dismiss the callout. I seconded this approach and suggested we should updateEuiModal
to have this same source order.Proposed solution
WCAG or Vendor Guidance (optional)
Screenshots or Trace Logs
The text was updated successfully, but these errors were encountered: