Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datepicker refresh interval should not be allowed to go negative #6153

Closed
LeeDr opened this issue Aug 22, 2022 · 3 comments
Closed

Datepicker refresh interval should not be allowed to go negative #6153

LeeDr opened this issue Aug 22, 2022 · 3 comments

Comments

@LeeDr
Copy link

LeeDr commented Aug 22, 2022

The number field shouldn't go below zero here. Image from 8.4.0

image

@chandlerprall
Copy link
Contributor

We use the input[type=number] element here which, by itself, doesn't allow additional configuration over content. We could probably intercept the key event and prevent the default browser action if it isn't a numeral or dot (/[0-9.]/). To handle using the down arrow in the spinner, we can similarly enforce a minimum value of 0. I don't think we'd want specific logic if an application passes a negative number, as the error state handling will continue working for that scenario.

Relates in concept to #5186, as both require a pattern for allowing users to get into, see, and edit error states without the error handling logic interrupting them.

@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@github-actions
Copy link

❌ We're automatically closing this issue due to lack of activity. Please comment if you feel this was done in error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants