Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with context menu in bottom bar on light mode #6063

Closed
brittanyjoiner15 opened this issue Jul 19, 2022 · 3 comments
Closed

Bug with context menu in bottom bar on light mode #6063

brittanyjoiner15 opened this issue Jul 19, 2022 · 3 comments
Labels

Comments

@brittanyjoiner15
Copy link

Found a workaround for this so don't need it fixed just for us, but wanted to point out in case it was a problem for others.

When a user is in light mode, the items on EuiContextMenu in the EuiBottomBar appear hidden.

Example from our app:

image

I was able to reproduce in this CodeSandBox

@elizabetdev
Copy link
Contributor

Hi @brittanyjoiner15,

It seems that this issue is related to the conversion of the EuiBottomBar to Emotion (#5823). The component is now wrapped in a EuiThemeProvider with the colorMode set to "dark".

The EuiPanel from the popover that was also converted to Emotion gets the color from the EuiThemeProvider.

So you can wrap the EuiPopover with a EuiThemeProvider with the colorMode set to "light" (See this CodeSandbox).

Screenshot 2022-07-20 at 16 39 35

In the future, all the components should inherit the EuiThemeProvider colorMode but right now the EuiPopover and the EuiContextMenu are not converted to Emotion. That's why only the panel gets the right colorMode.

@brittanyjoiner15
Copy link
Author

@miukimiu thanks for the response! that makes sense - i figured it was something to do with Bottom Bar really wanting to be dark mode and the elements inside of it getting confused 😂 Thanks for clearing that up!

@elizabetdev
Copy link
Contributor

Closing this issue. It will be solved once we finish all the Emotion conversions (#5685). 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants