-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiSearchBar] Add the option to render a hint below the bar #6005
Comments
Sounds good to me. Thinking through what happens as the user types, I think any @1Copenut what accessibility rules should we ensure to follow here? e.g. linking the hint to the input with an |
Yeah, I think |
Do you mean to render 2 different UIs depending if we detect that we are on mobile? If not we render the above design and if we are we render the hint below the label? |
Not specifically, I'm more asking a question. I'm all for consistency and brought it up because I'd seen that happen in past stops. Placement and UX aside, an |
Consider the hint as just a popover footer. If the search has typeahead, thats' the main popover content with the hint being at the bottom in the same container. If there's not typeahead, it's just the footer/hint. So not two UI's. |
Following on what @cchaos said, I have one addenda for automated test suites. If the hint (aria-describedby) block is in the typeahead footer, you will need to add the attribute to the input dynamically when the typeahead is shown. Otherwise the input will have an attribute looking for an ID that's not in the DOM, and automated a11y tests will throw an error. <main>
<h1>ARIA describedby test</h1>
<label for="input-test">Your name</label>
<!-- Text element with id="input-hint" must be in the DOM **or** -->
<!-- aria-describedby must be removed until the ID is present -->
<input aria-describedby="input-hint" id="input-test" type="text" value="" />
</main> |
As part of the work the improve UX for the
<TableListView />
in Kibana (the page rendering the list of dashboards, visualisations, maps) we want to be able to render a hint under the table search bar when the field is in focus.We will need to add a new prop to the search bar (
hint
) that accepts astring
orReactNode
to be passed.Design
The text was updated successfully, but these errors were encountered: