-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiContextMenu] tab key doesn't cycle through context menu items in Safari #5778
Comments
EuiDataGrid
popovers don't appear to own keyboard focus in Safari, which prevents item selection via keyboard
Thanks for finding & reporting! I can reproduce this in the context menu examples, not unique to the data grid example. I've renamed the issue to better reflect the buggy interaction. |
For even more fun times, Caroline and I are on Big Sur Safari v15.3 and are tabbing through https://elastic.github.io/eui/#/tabular-content/data-grid and the main ContextMenu examples just fine. It looks like Greg and Chandler are experiencing this buggy behavior though. It's unclear what the differences are between our setups that would lead to this discrepancy. Screencap of working Safari behavior: |
There's a Safari preference, Which modifies this behavior (I thought this only impacted links, I'm now not sure what Safari's heuristic here is). Turning that option on, I can tab between the menu items. As this is a difference in browser behaviour, and especially as tabbing between items goes against the WAI guidelines (#5737), I'm gonna drop the urgent label to allow discussion, but I'd lean toward closing this as a Won't Fix/Works as Intended. |
Ahah!! Yes, that's it, I had that checked - thank you Chandler. Do we know if that gets checked by default for Safari? |
I have never toggled it before today, and it was unchecked on my machine. |
I think it's off by default in Mac, I kinda remember turning it on back in the day. But I don't think it gets reset with any browser or OS update. Honestly, I think it's a terrible a11y misstep by Apple. But totally not our fault 😸 @andrew-goldstein Can you confirm if you can even tab to any other portion of the UI? |
The
Observations:
|
I guess my question here is whether this is considered intended behavior under Safari settings? (I would assume that Safari users that primarily use the keyboard for navigation would have this setting turned on.) If so, should we leave this as-is? |
Looks that way, we'd be overriding built-in browser behaviour that likely contradicts user expectations, echoing Caroline:
Closing as Works as Expected |
EuiDataGrid
popovers don't appear to own keyboard focus in Safari, which prevents item selection via keyboardEuiDataGrid
popovers in EUI versionv54.0.0
don't appear to own keyboard focus in Safari15.4
, which prevents item selection via keyboard✅ Chrome
100.0.4896.75
behaves as-expected✅ Firefox
99.0
behaves as-expectedTo reproduce:
Navigate to the Data grid documentation page: https://elastic.github.io/eui/#/tabular-content/data-grid
Using the keyboard, navigate to any
...
button in the Actions column to select it, per the screenshot below:Press
Enter
to display the actions popoverPress the
Tab
key at least three times while the popover is openExpected result
Tab
enables item selection, per the video using Chrome100.0.4896.75
below:chrome_owns_focus.mov
Actual results
Per the video using Safari
15.4
below:Tab
is pressedTab
no longer cycles through items in the popover, preventing item selection via keyboardsafari_popover_focus.mov
The text was updated successfully, but these errors were encountered: