Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiTour] Styling issues #5112

Closed
cchaos opened this issue Aug 30, 2021 · 3 comments · Fixed by #5225
Closed

[EuiTour] Styling issues #5112

cchaos opened this issue Aug 30, 2021 · 3 comments · Fixed by #5225

Comments

@cchaos
Copy link
Contributor

cchaos commented Aug 30, 2021

There's a couple issues with EuiTour.

  1. The footer has a background color but it's breaking out of the popover's rounded corners.
  2. Should they have a max-width to ensure they don't stretch too wide?
@cchaos cchaos mentioned this issue Aug 30, 2021
Merged
5 tasks
@VKairon
Copy link

VKairon commented Aug 31, 2021

One more styling issue.
The Tour step is out of bound when the screen size is reduced.
image

@cchaos cchaos mentioned this issue Sep 29, 2021
Merged
10 tasks
@cchaos
Copy link
Contributor Author

cchaos commented Sep 29, 2021

I've setup a PR to fix the original issue, I'll make a new one about the positioning since it's not actually style related.

@cchaos
Copy link
Contributor Author

cchaos commented Sep 29, 2021

Made the issue: #5226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[EuiTour] Style and a11y fixes cchaos/eui
2 participants
@cchaos @VKairon