-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiDataGrid] Cell actions need 2 clicks in Firefox #4235
Comments
I want to work on a fix for this. @chandlerprall can I get assigned? |
@kshitij86 from https://github.com/elastic/eui/blob/master/CONTRIBUTING.md:
Please go for it! |
@kertal does this issue occur only with specific cell actions, like the ones in the |
It‘s a general issue, except for Chrome |
@kertal How can I add a custom cell action like that to an example? Do I have to set one of the |
@kshitij86 there's a good example in our docs, have a look: |
@kertal If you take a look at the examples, they are clickable with a single click. Sort of having trouble reproducing this on Linux Mint. Do you think it could be a MacOS specific issue with Firefox? |
this is possible, will check if it's also a Windows problem (when I'm allowed to used the windows machine), dear @timroes could you do linux flavored double check in Firefox? |
I checked on Linux Firefox 83.0, it does not seem to be an issue there. In the above linked docs page @kertal shared it's triggered by a single click. While I was trying to record the gif it happened to me once that it seemed not to trigger, but I have the feeling I might just not have hit the button in that case :D |
@timroes Yes as the icon doesn't appear unless you hover over the right side, even I thought I had reproduced the issue. |
I've checked again, and in the meantime, this has been fixes, so I'm closing it |
If the cell was not already focused, triggering a custom cell action takes 2 clicks in Safari and Firefox. First one focuses the cell, second one triggeres the action. Works as expected in Chrome
The text was updated successfully, but these errors were encountered: