-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EuiSteps - Support custom badges #2833
Comments
Just throwing in something to consider: there are some a11y improvements I'd like to make the current Currently, The problem with supporting both of those things however is that the I'm not sure what the best way forward is but just wanted to throw this out there before any dev work started. |
Just out of curiosity @stephmilovic. Would you rather have some sort of What's your timeline? If we whipped up the design code quickly, would you maybe have time to handle the interface side of something like that? |
Yes @snide I think a EuiComment component would be better than extending steps. I need this for |
@stephmilovic I agree with @snide that it seems forcing EuiStep into this configuration may not be the best path forward. And as I thought about it some more and looked at the screen you are trying to build, I think your solution can easily be created simply by using the EUI layout components. I double-checked my thinking on that and came up with this simple solution https://codesandbox.io/s/working-eui-fo43n?fontsize=14&hidenavigation=1&theme=dark. EuiStep also comes with some very specific and non-overridable accessibility concerns like text that is read by the screenreader to make sense of the detached numbering. This will mostly be non-sensical to screenreader users of your layout. I also agree with @snide that this (a comment system) could be very useful to other plugins. We're currently working on a Markdown component (#1491) that could be used as part of the comments component. |
For the use case @andreadelrio described above, it would be great to allow cc @hbharding |
Closing this since the majority of the asks are now available with |
|
I've been asked to implement the below design on the SIEM team for Case Management. I'd like to use the
EuiSteps
component combined with theEuiAvatar
component to achieve this. However, I'll need to be able to have a custom badge instead of the numbered step. Can the EUI team please add support for JSX elements being passed as custom badges?The text was updated successfully, but these errors were encountered: