Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SuperDatePicker date popover EuiTabs not firing TransitionEnd event properly #2403

Closed
adekau opened this issue Oct 7, 2019 · 5 comments · Fixed by #2165
Closed

SuperDatePicker date popover EuiTabs not firing TransitionEnd event properly #2403

adekau opened this issue Oct 7, 2019 · 5 comments · Fixed by #2165
Labels

Comments

@adekau
Copy link

adekau commented Oct 7, 2019

When messing with the EuiSuperDatePicker demo page, I notice that occasionally the tabs when selecting a date range box do not highlight, which interrupts your clicks into a text field.

Here's a gif of it:
eui_bug

I'm having a bit of trouble pinning down exactly what is causing this. It seems pretty non-deterministic but it's especially common when switching between date range popovers.

It's a bit annoying because the transitionend event fires when you click inside the popover so it interrupts a click on an input field and you have to click again to start typing.

@chandlerprall
Copy link
Contributor

Thank you for submitting this issue! I've found I can recreate this fairly reliably by opening the date selection popover and then double-clicking on the popover's anchor.

popover focus

@thompsongl
Copy link
Contributor

thompsongl commented Oct 9, 2019

This is tricky. I spent a few minutes looking into it and it appears to be due to a combination of:

Just noting some observations as I peel off of this for a bit. I'll circle back if no one else picks it up

@adekau
Copy link
Author

adekau commented Oct 10, 2019

I noticed this initially because I was trying to wrap this component as a web component for integration with an angular app. I figured I wasn't re-targeting the events correctly. This bug reproduces every time the popover is created when wrapped as a webcomponent for some reason.

https://github.com/potatofarms/reactwebcomponent/blob/master/src/app/eui-wc/eui-superdatepicker.webcomponent.ts

Not sure if that information is helpful or not. Thanks for your time looking into this!

@thompsongl
Copy link
Contributor

Good news: I think this will be fixed when #2366 merges.
EuiPopover was the root of the problem (as noted in my previous comment), and this addition appears to resolve it.

@adekau
Copy link
Author

adekau commented Oct 25, 2019

Issue as described in OP appears to be fixed, but noticed another similar issue when testing on the demo page: #2490

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants