Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EuiBottomBar needs a container prop similar to EuiPopover #1877

Closed
cchaos opened this issue Apr 23, 2019 · 3 comments
Closed

EuiBottomBar needs a container prop similar to EuiPopover #1877

cchaos opened this issue Apr 23, 2019 · 3 comments

Comments

@cchaos
Copy link
Contributor

cchaos commented Apr 23, 2019

.. to restrict it's bounds to or to sit inside of.

We can't yet use the EuiBottomBar in Kibana because it's always portaled and sits on top of the nav drawer and any flyouts.

@cjcenizal
Copy link
Contributor

Per discussion with @joshdover, to use EuiBottomBar in Kibana currently requires tracking the side nav collapsed state and applying custom styles to the bottom bar instance to resize it. This solution is brittle because sizes will be hardcoded, and ad hoc because it will need to be reimplemented in each app that uses this component.

I think there should be a core-level solution in Kibana so people don't need to reimplement this brittle ad hoc solution. Maybe this could be a global service like toasts, or it could be a utility component that consumers can instantiate, e.g. <KibanaControlBar core={core} /> (Josh's idea)?

@snide
Copy link
Contributor

snide commented Feb 10, 2020

This reminded me of something similar we had to do with Flyouts awhile ago. The answer was mostly to just use css overwrites, which as @cjcenizal correctly mentions is fairly brittle. All that said, they generally have stood up fairly well over time, and it's probably OK for the short term in y'all are blocked. I know we all want something better, but it surprisingly has been pretty resilient since its introduction sometime in the late 6.x range. Likely there's something you can do with sibling selectors to make something similar depending upon the selectors applied.

https://github.com/elastic/kibana/blob/master/src/core/public/chrome/ui/header/_index.scss#L11-L21

@cchaos
Copy link
Contributor Author

cchaos commented Sep 20, 2020

Closing this issue as we'll be deprecating EuiBottomBar for EuiControlBar and with the replacement of EuiNavdrawer with EuiCollapsibleNav, this request is outdated.

@cchaos cchaos closed this as completed Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants