Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiInMemoryTable] Support same Pagination props as EuiBasicTable #1274

Closed
chrisronline opened this issue Oct 31, 2018 · 3 comments
Closed
Labels
feature request ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible

Comments

@chrisronline
Copy link
Contributor

The EuiBasicTable supports multiple pagination options that are not supported in the EuiInMemoryTable

We should aim for parity here unless there is a strong reason for something to only exist in one.

@chandlerprall
Copy link
Contributor

I don't think this needs to be a breaking change; EuiInMemoryTable doesn't need to expose totalItemCount as it already tracks items, and it exchanges pageSize for initialPageSize - the only prop that is missing is pageIndex/initialPageIndex.

@igoristic
Copy link

You're right, for some reason I assumed that EuiBasicTable prop names are actually index and size instead of pageIndex and pageSize. And, that this improvement will be to make the names consistent

@cchaos cchaos added the ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible label Mar 16, 2020
@chandlerprall
Copy link
Contributor

#4038 introduced pageIndex & pageSize values to EuiInMemoryTable's pagination prop, further aligning on pagination value names & support. I feel the basic & in-memory paginations have been aligned enough to close this out, feel free to re-open with more details if something is missing.

@cchaos cchaos changed the title EuiInMemoryTable should support same Pagination props as EuiBasicTable [EuiInMemoryTable] Support same Pagination props as EuiBasicTable Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible
Projects
None yet
Development

No branches or pull requests

4 participants