From c9dcfb32313be93a4cdf9b2a60ff45e5234c7395 Mon Sep 17 00:00:00 2001 From: ffknob Date: Tue, 21 Jan 2020 14:05:07 -0300 Subject: [PATCH] EuiTablePagination: Adds data-test-subj to the EuiContextMenuItem (#2778) * Adds data-test-subj to the EuiContextMenuItem component rendered in EuiTablePagination * Changes how the data-test-subj value is set * Adds CHANGELOG line --- CHANGELOG.md | 1 + src/components/table/table_pagination/table_pagination.tsx | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 84f29b7b639..718fc17ac39 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ - Converted `EuiFilterButton` to TypeScript ([#2761](https://github.com/elastic/eui/pull/2761)) - Converted `EuiFilterSelectItem` to TypeScript ([#2761](https://github.com/elastic/eui/pull/2761)) - Converted `EuiFieldSearch` to TypeScript ([#2775](https://github.com/elastic/eui/pull/2775)) +- Added `data-test-subj` to the `EuiContextMenuItem` in `EuiTablePagination` ([#2778](https://github.com/elastic/eui/pull/2778)) **Bug fixes** diff --git a/src/components/table/table_pagination/table_pagination.tsx b/src/components/table/table_pagination/table_pagination.tsx index bf83e722257..3e97b246bdb 100644 --- a/src/components/table/table_pagination/table_pagination.tsx +++ b/src/components/table/table_pagination/table_pagination.tsx @@ -75,7 +75,8 @@ export class EuiTablePagination extends Component { onClick={() => { this.closePopover(); onChangeItemsPerPage(itemsPerPageOption); - }}> + }} + data-test-subj={`tablePagination-${itemsPerPageOption}-rows`}>