Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up some unused components #93565

Merged
merged 5 commits into from
Feb 7, 2023

Conversation

joegallo
Copy link
Contributor

@joegallo joegallo commented Feb 7, 2023

Replaces #93557

A bit of followup from #93522 and #93438, I noticed some unused components hanging around, so I did a round of tree-shaking to see what could be dropped.

@joegallo joegallo added >non-issue :Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team v8.7.0 labels Feb 7, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

Copy link
Contributor

@mark-vieira mark-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you identify the items to remove? The tricky thing with this file is if you regenerate it from scratch, it'll only include artifacts that were resolved in the current build. We have lots of different possible tasks to execute that all require different artifacts and some are even host platform specific so it's hard to create a single build that constitutes all possible required artifacts. That's why creating the iniital file was a bit of a game of trial and error.

gradle/verification-metadata.xml Outdated Show resolved Hide resolved
gradle/verification-metadata.xml Outdated Show resolved Hide resolved
gradle/verification-metadata.xml Outdated Show resolved Hide resolved
@joegallo
Copy link
Contributor Author

joegallo commented Feb 7, 2023

How did you identify the items to remove? The tricky thing with this file is if you regenerate it from scratch, it'll only include artifacts that were resolved in the current build. We have lots of different possible tasks to execute that all require different artifacts and some are even host platform specific so it's hard to create a single build that constitutes all possible required artifacts. That's why creating the iniital file was a bit of a game of trial and error.

Trial and error -- I cleared out all the components and then pushed a build through, adding things back in until I got CI to go green.

@joegallo joegallo merged commit b61f60a into elastic:main Feb 7, 2023
@joegallo joegallo deleted the remove-unused-components branch February 7, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Build Build or test infrastructure >non-issue Team:Delivery Meta label for Delivery team v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants