Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease queue capacity in EnrichResiliencyTests for resiliency #93506

Conversation

gmarouli
Copy link
Contributor

@gmarouli gmarouli commented Feb 6, 2023

Fixes #82719 according to the recommendation in #82719 (comment).

I think this failed in CI, because of slowness. The executes a bulk request with a number of index requests (50) and then assumes that some of these index requests failed, because enrich queue was at capacity. The queue capacity is set to 10. I think we should to set the queue size to an even smaller value, like 2. To make it likely to reach queue capacity when test execution is slow.

In the mentioned build failure, it took 12 seconds to run this test, while locally here it takes 707 ms.

@gmarouli gmarouli added >test Issues or PRs that are addressing/adding tests :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) labels Feb 6, 2023
@elasticsearchmachine elasticsearchmachine added Team:Data Management Meta label for data/management team v8.7.0 labels Feb 6, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine elasticsearchmachine merged commit fc974cd into elastic:main Feb 6, 2023
@gmarouli gmarouli deleted the decrease-queue-capacity-enrich-resiliency-test-82719 branch February 6, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP Team:Data Management Meta label for data/management team >test Issues or PRs that are addressing/adding tests v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] EnrichResiliencyTests testWriteThreadLivenessWithPipeline failing
2 participants