Expose forecasted and actual disk usage per tier and node #93497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idegtiarenko
added
>non-issue
:Distributed/Allocation
|
Documentation preview: |
|
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
approved these changes
Feb 6, 2023
Comment on lines
22
to
23
| Where `actual_disk_usage` is computed using shard sizes from cluster info only | ||
| and `forecast_disk_usage` uses shard size forecast when available. |
There was a problem hiding this comment.
We really want to document the whole structure of the response, but we can do this when the API is no longer /_internal/.... For now, I think it would be better to remove these lines.
| @@ -155,31 +170,43 @@ public XContentBuilder toXContent(XContentBuilder builder, Params params) throws | |||
| } | |||
| } | |||
|
|
|||
| public record NodeBalanceStats(int shards, double forecastWriteLoad, long forecastShardSize) implements Writeable, ToXContentObject { | |||
| public record NodeBalanceStats(int shards, double forecastWriteLoad, long forecastShardSize, long actualShardSize) | |||
There was a problem hiding this comment.
Now that I think about it, it'd be awfully nice to see the watermarks in these stats too!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.