Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Adds size parameter details to aggregating data for faster performance page #93475

Merged
merged 2 commits into from
Feb 2, 2023

Conversation

szabosteve
Copy link
Contributor

Overview

This PR adds a recommendation for using the size parameter in a non-composite aggregation.

Preview

Aggregations

@szabosteve szabosteve added >docs General docs changes :ml Machine learning Team:Docs Meta label for docs team v8.7.0 v8.5.4 v8.6.2 labels Feb 2, 2023
@szabosteve szabosteve requested a review from lcawl February 2, 2023 16:49
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

Documentation preview:

@@ -34,6 +34,10 @@ to match. For example, if you use a `max` aggregation on a time field called
descending order. Additional `composite` aggregation value sources are allowed,
such as `terms`.

* The `size` parameter of the non-composite aggregations must be configured
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

must be configured properly to match

Could we just say "must match" instead?

Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise LGTM

@szabosteve szabosteve marked this pull request as ready for review February 2, 2023 17:26
@elasticsearchmachine elasticsearchmachine added the Team:ML Meta label for the ML team label Feb 2, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@szabosteve
Copy link
Contributor Author

@elasticsearchmachine test this please

@szabosteve
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.6
8.5

Questions ?

Please refer to the Backport tool documentation

szabosteve added a commit to szabosteve/elasticsearch that referenced this pull request Feb 2, 2023
szabosteve added a commit to szabosteve/elasticsearch that referenced this pull request Feb 2, 2023
szabosteve added a commit that referenced this pull request Feb 2, 2023
szabosteve added a commit that referenced this pull request Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :ml Machine learning Team:Docs Meta label for docs team Team:ML Meta label for the ML team v8.5.4 v8.6.2 v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants