Fix thirdPartyAudit tasks when running with Java 20 #93394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-vieira
added
>non-issue
:Delivery/Build
|
Pinging @elastic/es-delivery (Team:Delivery) |
💚 Backport successful
|
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Feb 1, 2023
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our third party audit task isn't smart enough to ignore classes that are compiled with
--enable-preview. Lucene includes Java 19 specific classes that use the new Project Panama foreign memory API. This API however has changed in Java 20 with the removal of theMemorySessioninterface. Until apache/lucene#12042 is merged and integrated into Elasticsearch, we'll need to ignore this for now.