-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust number of replicas in YAML REST tests #93386
Conversation
@@ -22,7 +22,6 @@ setup: | |||
- do: | |||
index: | |||
index: test | |||
refresh: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to replace these with a refresh call? (I thought it should work as is).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test should indeed work as it is. I changed this because Index requests with immediate refresh should be used to make the doc searchable immediately after it is indexed, which is not useful here. But your comment makes me notice that the Refresh call I added was on all indices instead of just test
(I pushed 38ff9b7)
Tests are green but let's run them again: |
Tests are green but let's run them again: |
1 similar comment
Tests are green but let's run them again: |
Pinging @elastic/es-search (Team:Search) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see anything standing out. But I'll leave main approval to one of the other two reviewers.
Thanks Iraklis and Ievgen! |
In #93386 we adjusted some YAML tests to allow their execution on a 2 nodes cluster where every index has at least 1 replica, but this caused test failures for single or multi node clusters. This pull request reverts the changes that was made. Those tests will be muted for the 2 nodes cluster. Closes #93572 Closes #93599
In elastic#93386 we adjusted some YAML tests to allow their execution on a 2 nodes cluster where every index has at least 1 replica, but this caused test failures for single or multi node clusters. This pull request reverts the changes that was made. Those tests will be muted for the 2 nodes cluster. Closes elastic#93572 Closes elastic#93599
In #93386 we adjusted some YAML tests to allow their execution on a 2 nodes cluster where every index has at least 1 replica, but this caused test failures for single or multi node clusters. This pull request reverts the changes that was made. Those tests will be muted for the 2 nodes cluster. Closes #93572 Closes #93599
In elastic#93386 we adjusted some YAML tests to allow their execution on a 2 nodes cluster where every index has at least 1 replica, but this caused test failures for single or multi node clusters. This pull request reverts the changes that was made. Those tests will be muted for the 2 nodes cluster. Closes elastic#93572 Closes elastic#93599
Some core yaml rest tests use an explicit number of replicas when creating indices. I suspect that this is often not needed and it prevents those tests to run in a 2 nodes (index & search) cluster.
Most of the impacted tests are search related so I'll use the
:Search/Search
label.Relates ES-5253