Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust number of replicas in YAML REST tests #93386

Merged
merged 7 commits into from
Feb 7, 2023

Conversation

tlrx
Copy link
Member

@tlrx tlrx commented Jan 31, 2023

Some core yaml rest tests use an explicit number of replicas when creating indices. I suspect that this is often not needed and it prevents those tests to run in a 2 nodes (index & search) cluster.

Most of the impacted tests are search related so I'll use the :Search/Search label.

Relates ES-5253

@tlrx tlrx added >test Issues or PRs that are addressing/adding tests v8.7.0 :Search/Search Search-related issues that do not fall into other categories labels Jan 31, 2023
@@ -22,7 +22,6 @@ setup:
- do:
index:
index: test
refresh: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to replace these with a refresh call? (I thought it should work as is).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test should indeed work as it is. I changed this because Index requests with immediate refresh should be used to make the doc searchable immediately after it is indexed, which is not useful here. But your comment makes me notice that the Refresh call I added was on all indices instead of just test (I pushed 38ff9b7)

@tlrx
Copy link
Member Author

tlrx commented Feb 2, 2023

Tests are green but let's run them again:
@elasticmachine run elasticsearch-ci/part-1
@elasticmachine run elasticsearch-ci/part-2
@elasticmachine run elasticsearch-ci/part-3

@tlrx
Copy link
Member Author

tlrx commented Feb 2, 2023

Tests are green but let's run them again:
@elasticmachine run elasticsearch-ci/part-1
@elasticmachine run elasticsearch-ci/part-2
@elasticmachine run elasticsearch-ci/part-3

1 similar comment
@tlrx
Copy link
Member Author

tlrx commented Feb 2, 2023

Tests are green but let's run them again:
@elasticmachine run elasticsearch-ci/part-1
@elasticmachine run elasticsearch-ci/part-2
@elasticmachine run elasticsearch-ci/part-3

@tlrx tlrx marked this pull request as ready for review February 2, 2023 14:17
@elasticsearchmachine elasticsearchmachine added the Team:Search Meta label for search team label Feb 2, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

Copy link
Contributor

@kingherc kingherc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything standing out. But I'll leave main approval to one of the other two reviewers.

@tlrx tlrx mentioned this pull request Feb 7, 2023
@tlrx tlrx merged commit a173001 into elastic:main Feb 7, 2023
@tlrx tlrx deleted the more-yaml-tests-take-2 branch February 7, 2023 13:35
@tlrx
Copy link
Member Author

tlrx commented Feb 7, 2023

Thanks Iraklis and Ievgen!

tlrx added a commit that referenced this pull request Feb 14, 2023
In #93386 we adjusted some YAML tests to allow their execution 
on a 2 nodes cluster where every index has at least 1 replica, but 
this caused test failures for single or multi node clusters.

This pull request reverts the changes that was made. Those tests 
will be muted for the 2 nodes cluster.

Closes #93572
Closes #93599
tlrx added a commit to tlrx/elasticsearch that referenced this pull request Feb 14, 2023
In elastic#93386 we adjusted some YAML tests to allow their execution 
on a 2 nodes cluster where every index has at least 1 replica, but 
this caused test failures for single or multi node clusters.

This pull request reverts the changes that was made. Those tests 
will be muted for the 2 nodes cluster.

Closes elastic#93572
Closes elastic#93599
elasticsearchmachine pushed a commit that referenced this pull request Feb 14, 2023
In #93386 we adjusted some YAML tests to allow their execution 
on a 2 nodes cluster where every index has at least 1 replica, but 
this caused test failures for single or multi node clusters.

This pull request reverts the changes that was made. Those tests 
will be muted for the 2 nodes cluster.

Closes #93572
Closes #93599
carlosdelest pushed a commit to carlosdelest/elasticsearch that referenced this pull request Feb 21, 2023
In elastic#93386 we adjusted some YAML tests to allow their execution 
on a 2 nodes cluster where every index has at least 1 replica, but 
this caused test failures for single or multi node clusters.

This pull request reverts the changes that was made. Those tests 
will be muted for the 2 nodes cluster.

Closes elastic#93572
Closes elastic#93599
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team >test Issues or PRs that are addressing/adding tests v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants