Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document datehistogram with long offsets #93328

Merged

Conversation

craigtaverner
Copy link
Contributor

When offsets are longer than calendar_intervals that are non-standard, like months which differ in length, then the usual rule of all buckets starting at the same day and time will no longer apply.

This update attempts to explain this with examples.

Fixes: #93180

@craigtaverner craigtaverner added >docs General docs changes :Analytics/Aggregations Aggregations Team:Docs Meta label for docs team Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Jan 27, 2023
@github-actions
Copy link
Contributor

Documentation preview:

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

When offsets are longer than calendar_intervals that are non-standard,
like months which differ in length, then the usual rule of all buckets
starting at the same day and time will no longer apply.

This update attempts to explain this with examples.
These don't seem to be parsable, even though they match the syntax
described in the README.asciidoc
Copy link
Contributor

@abdonpijpelink abdonpijpelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a docs perspective. I've left some minor suggestions.

craigtaverner and others added 4 commits February 6, 2023 16:04
…sciidoc

Co-authored-by: Abdon Pijpelink <abdon.pijpelink@elastic.co>
…sciidoc

Co-authored-by: Abdon Pijpelink <abdon.pijpelink@elastic.co>
…sciidoc

Co-authored-by: Abdon Pijpelink <abdon.pijpelink@elastic.co>
…sciidoc

Co-authored-by: Abdon Pijpelink <abdon.pijpelink@elastic.co>
@craigtaverner craigtaverner added auto-backport-and-merge Automatically create backport pull requests and merge when ready v8.6.2 labels Feb 6, 2023
@craigtaverner craigtaverner merged commit f55d70a into elastic:main Feb 6, 2023
@craigtaverner craigtaverner deleted the datehistogram_long_offsets branch February 6, 2023 15:20
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.6

craigtaverner added a commit to craigtaverner/elasticsearch that referenced this pull request Feb 6, 2023
* Document datehistogram with long offsets

When offsets are longer than calendar_intervals that are non-standard,
like months which differ in length, then the usual rule of all buckets
starting at the same day and time will no longer apply.

This update attempts to explain this with examples.

* Removed TEST-skip lines

These don't seem to be parsable, even though they match the syntax
described in the README.asciidoc

* Added // TESTRESPONSE[skip:...] lines

* Refined docs description and added more examples

* Update docs/reference/aggregations/bucket/datehistogram-aggregation.asciidoc

Co-authored-by: Abdon Pijpelink <abdon.pijpelink@elastic.co>

* Update docs/reference/aggregations/bucket/datehistogram-aggregation.asciidoc

Co-authored-by: Abdon Pijpelink <abdon.pijpelink@elastic.co>

* Update docs/reference/aggregations/bucket/datehistogram-aggregation.asciidoc

Co-authored-by: Abdon Pijpelink <abdon.pijpelink@elastic.co>

* Update docs/reference/aggregations/bucket/datehistogram-aggregation.asciidoc

Co-authored-by: Abdon Pijpelink <abdon.pijpelink@elastic.co>

---------

Co-authored-by: Abdon Pijpelink <abdon.pijpelink@elastic.co>
elasticsearchmachine pushed a commit that referenced this pull request Feb 6, 2023
* Document datehistogram with long offsets

When offsets are longer than calendar_intervals that are non-standard,
like months which differ in length, then the usual rule of all buckets
starting at the same day and time will no longer apply.

This update attempts to explain this with examples.

* Removed TEST-skip lines

These don't seem to be parsable, even though they match the syntax
described in the README.asciidoc

* Added // TESTRESPONSE[skip:...] lines

* Refined docs description and added more examples

* Update docs/reference/aggregations/bucket/datehistogram-aggregation.asciidoc



* Update docs/reference/aggregations/bucket/datehistogram-aggregation.asciidoc



* Update docs/reference/aggregations/bucket/datehistogram-aggregation.asciidoc



* Update docs/reference/aggregations/bucket/datehistogram-aggregation.asciidoc



---------

Co-authored-by: Abdon Pijpelink <abdon.pijpelink@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations auto-backport-and-merge Automatically create backport pull requests and merge when ready >docs General docs changes Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Docs Meta label for docs team v8.6.2 v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Date histogram aggregation unexpected result with calendar_interval and offset >= 30 days
4 participants