-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document datehistogram with long offsets #93328
Document datehistogram with long offsets #93328
Conversation
Documentation preview: |
Pinging @elastic/es-analytics-geo (Team:Analytics) |
Pinging @elastic/es-docs (Team:Docs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
When offsets are longer than calendar_intervals that are non-standard, like months which differ in length, then the usual rule of all buckets starting at the same day and time will no longer apply. This update attempts to explain this with examples.
These don't seem to be parsable, even though they match the syntax described in the README.asciidoc
c9ff4e2
to
fa46605
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from a docs perspective. I've left some minor suggestions.
docs/reference/aggregations/bucket/datehistogram-aggregation.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/aggregations/bucket/datehistogram-aggregation.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/aggregations/bucket/datehistogram-aggregation.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/aggregations/bucket/datehistogram-aggregation.asciidoc
Outdated
Show resolved
Hide resolved
…sciidoc Co-authored-by: Abdon Pijpelink <abdon.pijpelink@elastic.co>
…sciidoc Co-authored-by: Abdon Pijpelink <abdon.pijpelink@elastic.co>
…sciidoc Co-authored-by: Abdon Pijpelink <abdon.pijpelink@elastic.co>
…sciidoc Co-authored-by: Abdon Pijpelink <abdon.pijpelink@elastic.co>
💚 Backport successful
|
* Document datehistogram with long offsets When offsets are longer than calendar_intervals that are non-standard, like months which differ in length, then the usual rule of all buckets starting at the same day and time will no longer apply. This update attempts to explain this with examples. * Removed TEST-skip lines These don't seem to be parsable, even though they match the syntax described in the README.asciidoc * Added // TESTRESPONSE[skip:...] lines * Refined docs description and added more examples * Update docs/reference/aggregations/bucket/datehistogram-aggregation.asciidoc Co-authored-by: Abdon Pijpelink <abdon.pijpelink@elastic.co> * Update docs/reference/aggregations/bucket/datehistogram-aggregation.asciidoc Co-authored-by: Abdon Pijpelink <abdon.pijpelink@elastic.co> * Update docs/reference/aggregations/bucket/datehistogram-aggregation.asciidoc Co-authored-by: Abdon Pijpelink <abdon.pijpelink@elastic.co> * Update docs/reference/aggregations/bucket/datehistogram-aggregation.asciidoc Co-authored-by: Abdon Pijpelink <abdon.pijpelink@elastic.co> --------- Co-authored-by: Abdon Pijpelink <abdon.pijpelink@elastic.co>
* Document datehistogram with long offsets When offsets are longer than calendar_intervals that are non-standard, like months which differ in length, then the usual rule of all buckets starting at the same day and time will no longer apply. This update attempts to explain this with examples. * Removed TEST-skip lines These don't seem to be parsable, even though they match the syntax described in the README.asciidoc * Added // TESTRESPONSE[skip:...] lines * Refined docs description and added more examples * Update docs/reference/aggregations/bucket/datehistogram-aggregation.asciidoc * Update docs/reference/aggregations/bucket/datehistogram-aggregation.asciidoc * Update docs/reference/aggregations/bucket/datehistogram-aggregation.asciidoc * Update docs/reference/aggregations/bucket/datehistogram-aggregation.asciidoc --------- Co-authored-by: Abdon Pijpelink <abdon.pijpelink@elastic.co>
When offsets are longer than calendar_intervals that are non-standard, like months which differ in length, then the usual rule of all buckets starting at the same day and time will no longer apply.
This update attempts to explain this with examples.
Fixes: #93180