Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEST] Fix staleness in fetching component templates #93321

Merged
merged 2 commits into from
Jan 31, 2023
Merged

[TEST] Fix staleness in fetching component templates #93321

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
275c477
[TEST] Retry fetching component templates
Jan 27, 2023
23e8a12
Use metadata version to get the latest state.
Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions ...erTest/java/org/elasticsearch/reservedstate/service/ComponentTemplatesFileSettingsIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,15 +399,17 @@ private void assertClusterStateSaveOK(CountDownLatch savedClusterState, AtomicLo
boolean awaitSuccessful = savedClusterState.await(20, TimeUnit.SECONDS);
assertTrue(awaitSuccessful);

final var response = client().execute(
GetComposableIndexTemplateAction.INSTANCE,
new GetComposableIndexTemplateAction.Request("template*")
).get();

assertThat(
response.indexTemplates().keySet().stream().collect(Collectors.toSet()),
containsInAnyOrder("template_1", "template_2", "template_other")
);
assertBusy(() -> {
final var response = client().execute(
GetComposableIndexTemplateAction.INSTANCE,
new GetComposableIndexTemplateAction.Request("template*")
).get();

assertThat(
response.indexTemplates().keySet().stream().collect(Collectors.toSet()),
containsInAnyOrder("template_1", "template_2", "template_other")
);
}, 60L, TimeUnit.SECONDS);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From direct conversation: Can we wait for the appropriate metadata version? The issue, as ya mentioned in conversation, is GetComposableIndexTemplate may be stale.


assertTrue(
expectThrows(
Expand Down Expand Up @@ -531,7 +533,6 @@ public void clusterChanged(ClusterChangedEvent event) {
return new Tuple<>(savedClusterState, metadataVersion);
}

@AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/93202")
public void testSettingsApplied() throws Exception {
internalCluster().setBootstrapMasterNodeIndex(0);
logger.info("--> start data node / non master node");
Expand Down