[TEST] Fix staleness in fetching component templates #93321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Result from the API call seems behind the most recent state. This change adds a retry of the call to ensure we fetch the most recent state.
grcevski
added
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
stu-elastic
reviewed
Jan 31, 2023
| response.indexTemplates().keySet().stream().collect(Collectors.toSet()), | ||
| containsInAnyOrder("template_1", "template_2", "template_other") | ||
| ); | ||
| }, 60L, TimeUnit.SECONDS); |
There was a problem hiding this comment.
From direct conversation: Can we wait for the appropriate metadata version? The issue, as ya mentioned in conversation, is GetComposableIndexTemplate may be stale.
stu-elastic
approved these changes
Jan 31, 2023
grcevski
changed the title
|
Thanks Stu! |
💚 Backport successful
|
grcevski
added a commit
to grcevski/elasticsearch
that referenced
this pull request
Jan 31, 2023
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Result from the API call seems behind the most recent state. This change changes how we fetch the templates to ensure we use the most recent metadata version.
Based on the server logs we did write the index and component templates as we should've, but the API call made doesn't find them occasionally. I believe this is because the state hasn't propagated fully so we should retry the API call for a bit.
From the logs:
Closes #93202