Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testSearchRouting #93319

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Fix testSearchRouting #93319

merged 1 commit into from
Jan 30, 2023

Conversation

idegtiarenko
Copy link
Contributor

In some unlucky situations the test sets a preference for shard 1
and a routing that points to a completely different shard.
Updating the test so it is setting only one of them at the time.

Closes: #93292

In some unlucky situations the test sets a prefference for shard 1
and a routing that points to a completely different shard.
Updating the test so it is setting only one of them at the time.
@idegtiarenko idegtiarenko added >test Issues or PRs that are addressing/adding tests :Distributed/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) Team:Distributed Meta label for distributed team v8.7.0 labels Jan 27, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@idegtiarenko idegtiarenko merged commit 3eed4f4 into elastic:main Jan 30, 2023
@idegtiarenko idegtiarenko deleted the 93292_fix branch January 30, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) Team:Distributed Meta label for distributed team >test Issues or PRs that are addressing/adding tests v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] ShardRoutingRoleIT testSearchRouting failing
3 participants