Remove length check for source-only keyword fields #93299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 8.2 we check keyword fields length against Lucenes MAX_TERM_LENGTH size before indexing to prevent later errors and potential need for rollbacks (see 83738). This, however, currently also triggers even if the field is defined as not-indexed, not stored and without doc-values (effectively a source-only field). In this case, we don't need to apply the length check, making storing larger source-only keyword fields possible as before. Closes elastic#93046
cbuescher
added
>bug
:Search Foundations/Mapping
|
Pinging @elastic/es-search (Team:Search) |
|
Hi @cbuescher, I've created a changelog YAML for you. |
cbuescher
changed the title
|
@elasticsearchmachine update branch |
|
@elasticmachine update branch |
jmuscireum
added a commit
to scireum/sirius-biz
that referenced
this pull request
Apr 20, 2023
ES < 8.7.0 has a bug were it wrongfully raises an error for fields longer than 32766 that are not indexed in lucene (see elastic/elasticsearch#93299). This PR introduces a temporary limit on the length of some commonly long fields of logging entities and lowers the configured default length of LoggedMessage. We use 30k instead of 32766 as ES checks the byte length and not the character count. 30k should be good enough as the number of non-ASCII characters should be quite low. Fixes: SIRI-786
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 8.2 we check keyword fields length against Lucenes MAX_TERM_LENGTH size before indexing to prevent later errors and potential need for rollbacks (see #83738). This, however, currently also triggers even if the field is defined as not-indexed, not stored and without doc-values (effectively a source-only field). In this case, we don't need to apply the length check, making storing larger source-only keyword fields possible as before.
Closes #93046