Script: Optimize for the expected non-intersecting case #93279
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not expected that there are overlapping keys so optimize for the expected case -- we only actually need the intersection to build a friendly error message anyway.
joegallo
added
>enhancement
:Core/Infra/Scripting
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
Hi @joegallo, I've created a changelog YAML for you. |
|
@elasticmachine run elasticsearch-ci/part-1 |
rjernst
reviewed
Jan 26, 2023
| /** | ||
| * Compare two sets and return true if they have any overlapping keys. (That is, if there's an intersection.) | ||
| */ | ||
| private static boolean hasOverlappingKeys(Set<String> set1, Set<String> set2) { |
There was a problem hiding this comment.
This method is almost exactly what Sets.intersection does. It's going to be linear on the smaller set size. The only difference I see is in the common case creating a zero length set. Why is that zero length set a problem (something that we shouldn't create)?
There was a problem hiding this comment.
Actually, that's a really good point! Closing this in favor of #93284, that PR rewrites Sets.intersection to be faster, and so our calling it here is no longer expensive enough to warrant avoiding.
|
Closing this in favor of #93284 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not expected that there are overlapping keys so optimize for the expected case -- we only actually need the intersection to build a friendly error message anyway.