Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for search routing/preference with roles #93256

Merged

Conversation

DaveCTurner
Copy link
Contributor

No description provided.

@DaveCTurner DaveCTurner added >test Issues or PRs that are addressing/adding tests :Search/Search Search-related issues that do not fall into other categories v8.7.0 labels Jan 26, 2023
@DaveCTurner DaveCTurner requested a review from tlrx January 26, 2023 09:05
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@elasticsearchmachine elasticsearchmachine added the Team:Search Meta label for search team label Jan 26, 2023
Copy link
Member

@tlrx tlrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

assertThat(profileResults, not(anEmptyMap()));
for (final var searchShardProfileKey : profileResults.keySet()) {
assertThat(searchShardProfileKeys, hasItem(searchShardProfileKey));
}
}

// TODO also verify PIT routing
// TODO also verify the search-shards API
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😬

@DaveCTurner DaveCTurner merged commit e971ebe into elastic:main Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team >test Issues or PRs that are addressing/adding tests v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants