Make mutateInstance abstract #93229
Merged
Make mutateInstance abstract #93229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idegtiarenko
added
>test
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
rjernst
approved these changes
Jan 25, 2023
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 27, 2023
This is a follow up to #93229 to fix one of our example plugin tests.
idegtiarenko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr makes
mutateInstancenon abstract so that it must be implemented when creating a new tests based onAbstractWireTestCase. Existing test cases that are not implementing it yet are updated with empty implementation with a todo pointing to the original issue.Related to: #25929