Remove user exception marker from server cli #93206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously UserExceptions could be thrown from the main Elasticsearch process during startup. With recent refactorings all remaining validation of arguments was moved to the server cli. Since there are no longer any uses of the user exception in server, the marker code is no longer needed. This commit removes that marker and the associated code in the server cli error pump.
rjernst
added
>refactoring
:Core/Infra/CLI
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
thecoop
reviewed
Jan 24, 2023
distribution/tools/server-cli/src/main/java/org/elasticsearch/server/cli/ErrorPumpThread.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously UserExceptions could be thrown from the main Elasticsearch process during startup. With recent refactorings all remaining validation of arguments was moved to the server cli. Since there are no longer any uses of the user exception in server, the marker code is no longer needed. This commit removes that marker and the associated code in the server cli error pump.