Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ActionListener<Long> instead of LongConsumer in segment generation listeners #93185

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Use ActionListener<Long> instead of LongConsumer in segment generation listeners #93185

merged 1 commit into from
Jan 24, 2023

Conversation

tlrx
Copy link
Member

@tlrx tlrx commented Jan 24, 2023

No description provided.

@tlrx tlrx added >non-issue :Distributed/Engine Anything around managing Lucene and the Translog in an open shard. v8.7.0 labels Jan 24, 2023
DaveCTurner
DaveCTurner approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlrx tlrx marked this pull request as ready for review January 24, 2023 08:19
@tlrx tlrx added the auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jan 24, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@elasticsearchmachine elasticsearchmachine added the Team:Distributed Meta label for distributed team label Jan 24, 2023
@elasticsearchmachine elasticsearchmachine merged commit 0c1e7db into elastic:main Jan 24, 2023
@tlrx tlrx deleted the fix-segment-generation-on-close branch January 24, 2023 08:41
@tlrx
Copy link
Member Author

tlrx commented Jan 24, 2023

Thanks David and Ievgen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idegtiarenko idegtiarenko idegtiarenko approved these changes

@DaveCTurner DaveCTurner DaveCTurner approved these changes

Assignees
No one assigned
Labels
auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed/Engine Anything around managing Lucene and the Translog in an open shard. >non-issue Team:Distributed Meta label for distributed team v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tlrx @elasticsearchmachine @idegtiarenko @DaveCTurner