Restore printing bootstrap checks as errors #93178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bootstrap check failures were unintentionally moved to the info level in the log output. This commit restores logging them as errors. closes elastic#93074
rjernst
added
>bug
:Core/Infra/CLI
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
Hi @rjernst, I've created a changelog YAML for you. |
grcevski
reviewed
Jan 23, 2023
| @@ -71,10 +71,10 @@ Environment environment() { | |||
| return nodeEnv.get(); | |||
| } | |||
|
|
|||
| void exitWithUserException(int exitCode, Exception e) { | |||
| err.print(USER_EXCEPTION_MARKER); | |||
There was a problem hiding this comment.
The stderr pump thread looks for this marker, I wonder if this changes that behaviour?
There was a problem hiding this comment.
It slightly changes the error path, but it effectively doesn't change the result because the pump still exits after the stream is closed, which happens when we exit the main process.
I plan to create a followup to remove USER_EXCEPTION_MARKER as it is now no longer used.
There was a problem hiding this comment.
Oh, I see now, the error pump finally has the latch decrement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bootstrap check failures were unintentionally moved to the info level in the log output. This commit restores logging them as errors.
closes #93074