Migrate org.elasticsearch.action to TransportVersion #93086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add initial set of javadocs
Add initial set of javadocs
TransportVersion tests
12 tasks
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
thecoop
commented
Jan 24, 2023
| @@ -235,7 +235,7 @@ protected void doInternalExecute(Task task, BulkRequest bulkRequest, String exec | |||
| } | |||
|
|
|||
| if (actionRequest instanceof IndexRequest ir) { | |||
| ir.checkAutoIdWithOpTypeCreateSupportedByVersion(minNodeVersion); | |||
| ir.checkAutoIdWithOpTypeCreateSupportedByVersion(minNodeVersion.transportVersion); | |||
There was a problem hiding this comment.
minNodeVersion will need to be migrated separately, its used in several other places
thecoop
commented
Jan 24, 2023
pgomulka
reviewed
Jan 25, 2023
| throw new IllegalArgumentException( | ||
| "can't use sort by shard count or repository name with node version [" + out.getVersion() + "]" | ||
| "can't use sort by shard count or repository name with version [" + out.getTransportVersion() + "]" |
There was a problem hiding this comment.
perhaps node->transport in the exception message would be useful?
| out.writeVInt(offset); | ||
| } else if (offset != 0) { | ||
| throw new IllegalArgumentException( | ||
| "can't use numeric offset in get snapshots request with node version [" + out.getVersion() + "]" | ||
| "can't use numeric offset in get snapshots request with version [" + out.getTransportVersion() + "]" |
There was a problem hiding this comment.
node->transport version might be more clear?
|
@elasticsearchmachine rerun elasticsearch-ci/part-2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate files in
org.elasticsearch.actionto use TransportVersion.Vast majority is
s/Version/TransportVersion/, with a couple of comments