Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test testMultiKnnClauses #93047

Merged
merged 5 commits into from
Jan 25, 2023

Conversation

benwtrent
Copy link
Member

The test uses random vectors, consequently it is possible that vector_1 values are much closer than vector_2 values. Increasing boost to ensure order.

closes #92940

@benwtrent benwtrent added >test Issues or PRs that are addressing/adding tests :Search Relevance/Vectors Vector search v8.7.0 labels Jan 18, 2023
@elasticsearchmachine elasticsearchmachine added the Team:Search Meta label for search team label Jan 18, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@benwtrent
Copy link
Member Author

@elasticmachine update branch

@benwtrent
Copy link
Member Author

@elasticmachine update branch

@benwtrent
Copy link
Member Author

run elasticsearch-ci/docs

Copy link
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@benwtrent benwtrent merged commit 43c8806 into elastic:main Jan 25, 2023
@benwtrent benwtrent deleted the test/fix-multi-knn-test-case-92940 branch January 25, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Search Relevance/Vectors Vector search Team:Search Meta label for search team >test Issues or PRs that are addressing/adding tests v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] KnnSearchSingleNodeTests testMultiKnnClauses failing
4 participants