Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve cluster alias for opened remote connections #92584

Merged
merged 6 commits into from
Jan 24, 2023

Conversation

n1v0lg
Copy link
Contributor

@n1v0lg n1v0lg commented Dec 28, 2022

#91724 introduced the ability to resolve the cluster alias, given a connection towards a remote cluster. This works for connections obtained via RemoteConnectionManager::getConnection. However, connections can also be initiated via openConnection (e.g., in SniffConnectionStrategy). This PR adds support to correctly resolve the cluster alias for such connections, by wrapping them in an InternalRemoteConnection instance. This is necessary to support the new remote cluster security model.

@n1v0lg n1v0lg added >non-issue :Distributed/Network Http and internode communication implementations :Security/Security Security issues without another label v8.7.0 labels Dec 28, 2022
@n1v0lg n1v0lg self-assigned this Dec 28, 2022
@n1v0lg n1v0lg marked this pull request as ready for review December 28, 2022 13:30
@elasticsearchmachine elasticsearchmachine added Team:Distributed Meta label for distributed team Team:Security Meta label for security team labels Dec 28, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

Copy link
Contributor

@slobodanadamovic slobodanadamovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@n1v0lg
Copy link
Contributor Author

n1v0lg commented Jan 17, 2023

Build failure unrelated and tracked here: #92930

Copy link
Contributor

@Tim-Brooks Tim-Brooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@n1v0lg
Copy link
Contributor Author

n1v0lg commented Jan 24, 2023

@elasticsearchmachine run elasticsearch-ci/part-2-fips

@n1v0lg n1v0lg merged commit ffabc7e into elastic:main Jan 24, 2023
@n1v0lg n1v0lg deleted the use-internal-remote-connection-on-open branch January 24, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed/Network Http and internode communication implementations >non-issue :Security/Security Security issues without another label Team:Distributed Meta label for distributed team Team:Security Meta label for security team v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants