Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reloading analyzers doesn't bust the request cache #66722

Open
nik9000 opened this issue Dec 21, 2020 · 2 comments
Open

Reloading analyzers doesn't bust the request cache #66722

nik9000 opened this issue Dec 21, 2020 · 2 comments
Labels
>bug priority:normal A label for assessing bug priority to be used by ES engineers :Search Relevance/Analysis How text is split into tokens Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch

Comments

@nik9000
Copy link
Member

nik9000 commented Dec 21, 2020

When working on #66295 @jtibshirani realized that reloading analyzers also doesn't clear the request cache when it probably should. We expect most folks that reload search analyzers probably aren't going to bump into this because they are likely to have non-0 top hits so they won't have the cache enabled by default. But search analyzers can play a part in queries the kind of pure aggregation queries that enable the request cache by default - they can filter the data seen by aggs and they define the filters aggs. Busting the cache when the analyzers is the safest thing from a "correctness" stand point. It is rare so it shouldn't cause a huge performance hit.
@nik9000 nik9000 added >bug :Search/Search Search-related issues that do not fall into other categories needs:triage Requires assignment of a team area label labels Dec 21, 2020
@elasticmachine elasticmachine added the Team:Search Meta label for search team label Dec 21, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@jtibshirani jtibshirani removed the needs:triage Requires assignment of a team area label label Dec 21, 2020
@jtibshirani jtibshirani mentioned this issue Dec 22, 2020
Merged
@nik9000 nik9000 mentioned this issue Dec 22, 2020
Open
28 tasks
fixmebot bot referenced this issue in VectorXz/elasticsearch Apr 22, 2021
@VectorXz
Create TestFixMe.md
a9fae03
@javanna javanna added :Search Relevance/Analysis How text is split into tokens and removed :Search/Search Search-related issues that do not fall into other categories labels Jun 17, 2022
@javanna javanna added Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch and removed Team:Search Meta label for search team labels Jul 12, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@javanna javanna added the priority:normal A label for assessing bug priority to be used by ES engineers label Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>bug priority:normal A label for assessing bug priority to be used by ES engineers :Search Relevance/Analysis How text is split into tokens Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nik9000 @javanna @jtibshirani @elasticmachine @elasticsearchmachine