You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #22200, existing boolean parsing was made strict so that:
"true" is converted to the boolean value true, "false" is converted to the boolean value false. Everything else raises an error.
However, usages of Boolean.parseBoolean have made their way into the codebase since then and the implementation of the JDKs boolean parsing logic is anything but strict as a string that is a case-insensitive match to true will be true and everything else will be false.
I think we should remove these usages of Boolean.parseBoolean after deprecation in the places where it was previously used and add this API to our forbidden-apis list.
The text was updated successfully, but these errors were encountered:
It is unfortunate we let this lapse; a lot of work went into removing uses of lenient boolean parsing. It looks like most of the uses added are in tests, although there appear to be a couple that are user facing. +1 to adding the method to forbidden apis to stop the bleeding.
In #22200, existing boolean parsing was made strict so that:
However, usages of
Boolean.parseBoolean
have made their way into the codebase since then and the implementation of the JDKs boolean parsing logic is anything but strict as a string that is a case-insensitive match totrue
will be true and everything else will be false.I think we should remove these usages of
Boolean.parseBoolean
after deprecation in the places where it was previously used and add this API to our forbidden-apis list.The text was updated successfully, but these errors were encountered: