Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary sort_order, sort_mode keys from sort object #2781

Closed
s1monw opened this issue Mar 15, 2013 · 3 comments
Closed

Remove unnecessary sort_order, sort_mode keys from sort object #2781

s1monw opened this issue Mar 15, 2013 · 3 comments
Assignees
@s1monw
Labels
>breaking v0.90.0.Beta1

Comments

@s1monw
Copy link
Contributor

s1monw commented Mar 15, 2013

this came up due to #2767 since we had documentation issues that used sort_mode instead of mode in the sort object. I tried to make this consistent and added sort_order next to order since I though this was introduced before 0.90Beta1 but it wasn't so I'd rather drop those entirely. Any objections?
@ghost ghost assigned s1monw Mar 15, 2013
@clintongormley
Copy link

Agreed - should be order and mode only.

@kimchy
Copy link
Member

kimchy commented Mar 15, 2013

+1

@s1monw s1monw closed this as completed in e0eff7d Mar 15, 2013
@s1monw
Copy link
Contributor Author

s1monw commented Mar 15, 2013

pushed, thanks guys!

@s1monw s1monw mentioned this issue Mar 15, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s1monw s1monw

Labels
>breaking v0.90.0.Beta1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kimchy @clintongormley @s1monw