Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ignore_malformed for all non-string fields using synthetic source #106483

Closed
salvatore-campagna opened this issue Mar 19, 2024 · 2 comments

Comments

@salvatore-campagna
Copy link
Contributor

salvatore-campagna commented Mar 19, 2024

Description

Non-string fields need to support ignore_malformed when synthetic source is enabled. The idea is to store the field value "as-is" in its json representation and later use the the value reading it from a hidden stored field.

Here the strategy to adopt is similar to what we did for the ip type. We catch an exception happing when parsing the field value and if storing the malformed value is enabled we just use IgnoreMalformedStoredValues#storedField to store the value.

(Maybe we can do a nice refactoring before and avoid relying on catching the exception)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@salvatore-campagna salvatore-campagna changed the title Support ignore_malformed for all non-string fields using synthetic source Support ignore_malformed for all non-string fields using synthetic source Mar 19, 2024
@salvatore-campagna salvatore-campagna self-assigned this Mar 19, 2024
@siposea siposea assigned lkts and unassigned salvatore-campagna May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants