Fixing disk health indicator unit tests (#90175)

The disk health indicator unit tests had a couple of edge cases where they could fail if all test nodes had a red status. This protects against that.
elastic · Sep 20, 2022 · f4dd48e · f4dd48e
1 parent 4901cf8
commit f4dd48e
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/server/src/test/java/org/elasticsearch/health/node/DiskHealthIndicatorServiceTests.java b/server/src/test/java/org/elasticsearch/health/node/DiskHealthIndicatorServiceTests.java
@@ -739,7 +739,7 @@ public void testGetIndicesForNodes() {
         Set<String> nonRedNodeIndices = new HashSet<>();
         for (int i = 0; i < numberOfIndices; i++) {
             String indexName = randomAlphaOfLength(20);
-            if (randomBoolean()) {
+            if (nonRedNodeIds.isEmpty() || randomBoolean()) {
                 indexNameToNodeIdsMap.put(indexName, redNodeIds);
                 redNodeIndices.add(indexName);
             } else {
@@ -775,7 +775,7 @@ public void testGetNodeIdsForIndices() {
         Set<String> nonRedNodeIndices = new HashSet<>();
         for (int i = 0; i < numberOfIndices; i++) {
             String indexName = randomAlphaOfLength(20);
-            if (randomBoolean()) {
+            if (nonRedNodeIds.isEmpty() || randomBoolean()) {
                 indexNameToNodeIdsMap.put(indexName, redNodeIds);
                 redNodeIndices.add(indexName);
             } else {