From a12195c25137d52a9ee394e0046ff76a12515031 Mon Sep 17 00:00:00 2001 From: Nhat Nguyen Date: Sun, 8 Oct 2023 20:41:22 -0700 Subject: [PATCH] Reduce num docs in ValuesSourceReaderOperatorTests (#100469) The test failed because it took more than 30 seconds to extract fields for approximately 100,000 documents. With the randomized page size, we can make these tests more reliable and faster by reducing the number of documents. Closes #100235 --- .../compute/lucene/ValuesSourceReaderOperatorTests.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/lucene/ValuesSourceReaderOperatorTests.java b/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/lucene/ValuesSourceReaderOperatorTests.java index 4c0e33e5cfb82..3ce202c0e4608 100644 --- a/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/lucene/ValuesSourceReaderOperatorTests.java +++ b/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/lucene/ValuesSourceReaderOperatorTests.java @@ -202,7 +202,7 @@ public void testLoadAll() { DriverContext driverContext = driverContext(); loadSimpleAndAssert( driverContext, - CannedSourceOperator.collectPages(simpleInput(driverContext.blockFactory(), between(1_000, 100 * 1024))) + CannedSourceOperator.collectPages(simpleInput(driverContext.blockFactory(), between(100, 5000))) ); } @@ -212,7 +212,7 @@ public void testLoadAllInOnePage() { driverContext, List.of( CannedSourceOperator.mergePages( - CannedSourceOperator.collectPages(simpleInput(driverContext.blockFactory(), between(1_000, 100 * 1024))) + CannedSourceOperator.collectPages(simpleInput(driverContext.blockFactory(), between(100, 5000))) ) ) ); @@ -226,7 +226,7 @@ public void testEmpty() { public void testLoadAllInOnePageShuffled() { DriverContext driverContext = driverContext(); Page source = CannedSourceOperator.mergePages( - CannedSourceOperator.collectPages(simpleInput(driverContext.blockFactory(), between(1_000, 100 * 1024))) + CannedSourceOperator.collectPages(simpleInput(driverContext.blockFactory(), between(100, 5000))) ); List shuffleList = new ArrayList<>(); IntStream.range(0, source.getPositionCount()).forEach(i -> shuffleList.add(i)); @@ -384,7 +384,7 @@ public void testValuesSourceReaderOperatorWithNulls() throws IOException { NumericDocValuesField intField = new NumericDocValuesField(intFt.name(), 0); NumericDocValuesField longField = new NumericDocValuesField(longFt.name(), 0); NumericDocValuesField doubleField = new DoubleDocValuesField(doubleFt.name(), 0); - final int numDocs = 100_000; + final int numDocs = between(100, 5000); try (RandomIndexWriter w = new RandomIndexWriter(random(), directory)) { Document doc = new Document(); for (int i = 0; i < numDocs; i++) {