Fix node_pool_class override #2581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
|
Thanks! I've added a test. Does that look good to you? Are you OK with me reusing your |
|
buildkite test this please |
Sure, no problem! And thanks for adding the tests, should have taken the time to do it myself. This looks good now 👍 |
miguelgrinberg
approved these changes
May 31, 2024
pquentin
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Jun 5, 2024
Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co> (cherry picked from commit 7e9ea0d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its currently not working to submit a custom node_pool_class when creating a AsyncElasticsearch/Elasticsearch client. This PR fixes this.
Fixes #2578